From 435416508e1af0dcd8928cbed99cdd711a9d41ea Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Thu, 8 Oct 2026 17:13:53 +0100 Subject: [PATCH 1/3] Implement quote generator --- Sprint-3/quote-generator/quotes.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Sprint-3/quote-generator/quotes.js b/Sprint-3/quote-generator/quotes.js index 4a4d04b72..f105a97a3 100644 --- a/Sprint-3/quote-generator/quotes.js +++ b/Sprint-3/quote-generator/quotes.js @@ -1,3 +1,15 @@ +document.addEventListener("DOMContentLoaded", () => { + const {quote, author} = pickFromArray(quotes); + document.getElementById("quote").innerText = quote; + document.getElementById("author").innerText = author; +}); + +document.querySelector("button").addEventListener("click", () => { + const {quote, author} = pickFromArray(quotes); + document.getElementById("quote").innerText = quote; + document.getElementById("author").innerText = author; +}); + // DO NOT EDIT BELOW HERE // pickFromArray is a function which will return one item, at From d18e2b0e11d50195804b77fccd59e8a1cb8bd775 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Thu, 8 Oct 2026 17:25:04 +0100 Subject: [PATCH 2/3] Extract function to avoid duplication --- Sprint-3/quote-generator/quotes.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/Sprint-3/quote-generator/quotes.js b/Sprint-3/quote-generator/quotes.js index f105a97a3..a895bc104 100644 --- a/Sprint-3/quote-generator/quotes.js +++ b/Sprint-3/quote-generator/quotes.js @@ -1,14 +1,12 @@ -document.addEventListener("DOMContentLoaded", () => { +const showNewQuote = () => { const {quote, author} = pickFromArray(quotes); document.getElementById("quote").innerText = quote; document.getElementById("author").innerText = author; -}); +}; -document.querySelector("button").addEventListener("click", () => { - const {quote, author} = pickFromArray(quotes); - document.getElementById("quote").innerText = quote; - document.getElementById("author").innerText = author; -}); +document.addEventListener("DOMContentLoaded", () => { showNewQuote(); }); + +document.querySelector("button").addEventListener("click", () => { showNewQuote(); }); // DO NOT EDIT BELOW HERE From b7fd2a7ee9d61a64842d1e6c3f4ff87833ec7981 Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Thu, 8 Oct 2026 17:28:15 +0100 Subject: [PATCH 3/3] Don't wrap in functions --- Sprint-3/quote-generator/quotes.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sprint-3/quote-generator/quotes.js b/Sprint-3/quote-generator/quotes.js index a895bc104..e87b73d6b 100644 --- a/Sprint-3/quote-generator/quotes.js +++ b/Sprint-3/quote-generator/quotes.js @@ -4,9 +4,9 @@ const showNewQuote = () => { document.getElementById("author").innerText = author; }; -document.addEventListener("DOMContentLoaded", () => { showNewQuote(); }); +document.addEventListener("DOMContentLoaded", showNewQuote); -document.querySelector("button").addEventListener("click", () => { showNewQuote(); }); +document.querySelector("button").addEventListener("click", showNewQuote); // DO NOT EDIT BELOW HERE