From 042df2bce40a722fb9f3b6e8ebd619b57806b481 Mon Sep 17 00:00:00 2001 From: Brice Vallieres Date: Tue, 1 Sep 2026 11:20:34 +0000 Subject: [PATCH] ci: run CI on master, and build packages before type-check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both CI triggers pointed at a `main` branch that doesn't exist — the repo's default branch is `master` — so the CI workflow has never run once: every PR to date merged with zero checks. Fixing the branch name alone would turn CI red immediately, because `pnpm type-check` fails on a fresh checkout: workspace packages resolve each other's types from built dist output (e.g. tinypivot-server imports @smallwebco/tinypivot-core). Add a build step before type-check in the lint job. Verified locally in CI order: pnpm lint, pnpm build, pnpm type-check, pnpm test:unit — all green (241/241 tests). deploy.yml also watches `main` but is left untouched: it targets GitHub Pages, which is not enabled for this repo (the site deploys via Vercel), so pointing it at master would only add a failing workflow. --- .github/workflows/ci.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8114fa9..013a052 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,9 +2,9 @@ name: CI on: push: - branches: [main] + branches: [master] pull_request: - branches: [main] + branches: [master] # Cancel in-progress runs for the same branch concurrency: @@ -32,6 +32,11 @@ jobs: - name: Lint run: pnpm lint + # Workspace packages type-check against each other's built dist, + # so the packages must be built before type-check can pass. + - name: Build packages + run: pnpm build + - name: Type check run: pnpm type-check