Repository navigation
fix(azdo): ship valid Node24 task handlers and restore AzDO test and publish - #448
Open
Todor Genov (tgenov) wants to merge 3 commits into
Open
Todor Genov (tgenov) wants to merge 3 commits into
Todor Genov (tgenov) wants to merge 3 commits into
Conversation
The agent has no "Node20" handler (devcontainers#438). The valid keys are Node, Node10, Node16, Node20_1 and Node24 (tasks.schema.json). DevcontainersMerge used only the deprecated "Node16" (devcontainers#435). Declare Node24, Node20_1 and Node16 in both tasks. Agents pick Node24 first. Node16 keeps agents older than 3.230.2 working. The agent shows no deprecation warning when Node20_1 or Node24 is present. Refs devcontainers#444
GitHub deprecated Node 20 for actions. The runner notice gives 2026-09-16 as the removal date. Use node24, the same as action.yml.
devcontainers#441 commented out the AzDO test and publish steps, because the failing AzDO test blocked the GitHub Action release. - test-azdo is a job again. checks-succeeded and release do not need it, so an AzDO failure does not stop the GitHub Action release. - The publish step moves from release to a new publish-azdo job. It needs build, test-azdo and release. Refs devcontainers#444
Todor Genov (tgenov)
requested review from
a team and
Stuart Leeks (stuartleeks)
as code owners
October 13, 2026 21:52
Contributor
Author
|
@copilot review this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #444
Problem
The Marketplace extension
devcontainers.ciis at0.3.1900000417(2025-02-07). Its task usesNode16. This causes the warnings in #444. No publish ran after that date:CI (main)runs onmainfrom 2025-10-16 to 2026-04-16 failed in "Run AzDO test". The release needed that job. The logs have expired, so the root cause is not known.A publish of
maintoday would ship two more defects:DevcontainersCi/task.jsonusesNode20(Update Node, NPM, Go tools and Debian #438). The agent has noNode20handler. The valid keys areNode,Node10,Node16,Node20_1andNode24(tasks.schema.json).DevcontainersMerge/task.jsonuses onlyNode16. feat: native multi-platform builds via runner matrix (no QEMU emulation) #435 added it by mistake.Changes
task.jsonfiles declareNode24,Node20_1andNode16. Agents pickNode24first.Node16keeps agents older than 3.230.2 working. The agent shows no deprecation warning whenNode20_1orNode24is present (CheckIfTaskNodeRunnerIsDeprecated).merge/action.yml:node20→node24, the same asaction.yml. GitHub deprecated Node 20 for actions.ci_common.yml:test-azdois a job again.checks-succeededandreleasedo not need it, so an AzDO failure does not stop the GitHub Action release. The run shows the failure.publish-azdo. It runs afterrelease, and only iftest-azdopassed.I did not restore the
enableAzdoinput. Its expression gavetrueforfalse.Before merge (maintainer)
/testuses the workflows frommain, not from this PR. To test this change:devcontainers/ci. The AzDO pipeline can build only commits in that repo.prNumberto this PR. Without it,IMAGE_TAGis empty and the AzDO test stops.publish-azdodoes not run, becausereleaseisfalse.If the log shows a token error, replace
AZDO_TOKENor refresh its access (seeCONTRIBUTING.md).Security
This PR enables
test-azdoon/testagain. The job runs the PR's code withAZDO_TOKEN, as before #441.pr_autonever runs it. Any repository collaborator can send/test. Read the full diff before you send it.Verification
./scripts/build-local.shin the dev container (Node 24): passes. 49 tests incommonand 2 in the AzDO task pass.task.jsonfiles are in the schema.Node20onmainis not.actionlint1.7.7: no new findings.AZDO_TOKEN, the AzDO test pipeline, andDevcontainersMergein AzDO. The test pipeline does not use that task, so the first publish ships it untested.Follow-up (not in this PR)
DevcontainersMerge/task.jsonstays at0.0.0. The build sets the patch version forDevcontainersCionly. Agents cache tasks by version, so later changes may not reach them..devcontainer/Dockerfileinstallstfx-cliwith no version.