Commit edcc6e7
fix(smoke): replace unsatisfiable web-fetch check with curl egress check (#830)
* fix(smoke): replace unsatisfiable web-fetch check with curl egress check
The Codex CLI has no web-fetch tool — it only supports web_search. gh-aw's
`-c fetch="disabled"` toggle is a no-op config key, so the compiled lock was
already correct and test 2 could never pass. Swap it for a curl request to
github.com, which is already allow-listed by `network: github` and still
exercises egress through the AWF firewall.
Note: .lock.yml still needs recompiling with gh aw v0.86.1.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
* fix(smoke): fail the codex egress check on HTTP errors
`curl -sSL` exits 0 for 4xx/5xx responses, so an AWF/Squid denial page would
count as a successful fetch — and since that page can echo the requested URL,
it could even satisfy the substring check. Add `-f` so HTTP errors exit
non-zero, and require an exit code of 0 alongside the text match.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
---------
Co-authored-by: GitHub Ace <githubnext@users.noreply.github.com>
Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>1 parent 4eb9242 commit edcc6e7
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
0 commit comments