Skip to content

Clarify expected behavior of /@latest endpoint in fallback NetworkMode #1868

Description

@ngshiheng

Describe the bug

When attempting to use the /@latest endpoint in fallback NetworkMode with Athens as a Go module proxy, a 404 error is returned instead of retrieving the latest version from Athens' storage when VCS fails.

curl http://localhost:3000/gitlab.company.net/foo/bar/baz/@latest

# Athens server log

INFO[4:21PM]: incoming request  http-method=GET http-path=gitlab.company.net/foo/bar/baz/@latest http-status=404 request-id=4a40eff5-6aa8-4914-b4ba-89a9d0904b5e

Expected behavior

I would expect Athens to retrieve the latest version from its storage when the /@latest endpoint is called in fallback NetworkMode (to provide the best effort of giving the user what is available at the time of requesting versions) in the case when the VCS fails.

Environment (please complete the following information):

  • OS: osx/arm64
  • Go version: 1.19
  • Proxy version: v0.12.0
  • Storage (fs/mongodb/s3 etc.): s3

If this behavior is unintended, I would be happy to submit a pull request to help fix it. Please let me know if this is something that can be addressed or if you need any additional information from me.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions