Skip to content

Commit c8e2aaf

Browse files
authored
[MAINT] Remove skip markers because tests work again (#1781)
We had issues with a flaky tests, at least partially due to a flaky server (#1544). I tried to investigate but found that all tests currently work again. While I can see some ways to improve the tests, I want to defer that until more PRs are merged that affect the same files to avoid needlessly complicated merge conflicts. At the same time, I'd like to re-enable the tests to bring back coverage.
1 parent b9967b8 commit c8e2aaf

6 files changed

Lines changed: 6 additions & 7 deletions

File tree

‎tests/test_evaluations/test_evaluation_functions.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,8 @@ def test_list_evaluations_setups_filter_flow(self):
262262
keys = list(evals["parameters"].values[0].keys())
263263
assert all(elem in columns for elem in keys)
264264

265+
# 2026-10-20: Removed skip marker, test just works (#1544)
265266
@pytest.mark.production_server
266-
@pytest.mark.xfail(reason="failures_issue_1544", strict=False)
267267
def test_list_evaluations_setups_filter_task(self):
268268
self.use_production_server()
269269
task_id = [6]

‎tests/test_flows/test_flow.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ def test_get_flow(self):
7575
assert subflow_3.parameters["L"] == "-1"
7676
assert len(subflow_3.components) == 0
7777

78+
# 2026-10-20: Removed skip marker, test just works (#1544)
7879
@pytest.mark.production_server
79-
@pytest.mark.xfail(reason="failures_issue_1544", strict=False)
8080
def test_get_structure(self):
8181
# also responsible for testing: flow.get_subflow
8282
# We need to use the production server here because 4024 is not the

‎tests/test_flows/test_flow_functions.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,14 +270,14 @@ def test_are_flows_equal_ignore_if_older(self):
270270
)
271271
assert_flows_equal(flow, flow, ignore_parameter_values_on_older_children=None)
272272

273+
# 2026-10-20: Removed skip marker, test just works (#1544)
273274
@pytest.mark.sklearn
274275
@unittest.skipIf(
275276
Version(sklearn.__version__) < Version("0.20"),
276277
reason="OrdinalEncoder introduced in 0.20. "
277278
"No known models with list of lists parameters in older versions.",
278279
)
279280
@pytest.mark.test_server
280-
@pytest.mark.xfail(reason="failures_issue_1544", strict=False)
281281
def test_sklearn_to_flow_list_of_lists(self):
282282
from sklearn.preprocessing import OrdinalEncoder
283283

@@ -521,7 +521,6 @@ def test_delete_flow_success(mock_request, test_files_directory, test_server_v1,
521521

522522

523523
@mock.patch.object(requests.Session, "request")
524-
@pytest.mark.xfail(reason="failures_issue_1544", strict=False)
525524
def test_delete_unknown_flow(mock_request, test_files_directory, test_server_v1, test_apikey_v1):
526525
content_file = test_files_directory / "mock_responses" / "flows" / "flow_delete_not_exist.xml"
527526
mock_request.return_value = create_request_response(

‎tests/test_runs/test_run_functions.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1626,8 +1626,8 @@ def test_get_runs_list_by_filters(self):
16261626
)
16271627
assert len(runs) == 2
16281628

1629+
# 2026-10-20: Removed skip marker, test just works (#1544)
16291630
@pytest.mark.production_server
1630-
@pytest.mark.xfail(reason="failures_issue_1544", strict=False)
16311631
def test_get_runs_list_by_tag(self):
16321632
# We don't have tagged runs on the test server
16331633
self.use_production_server()

‎tests/test_study/test_study_functions.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
from openml.testing import TestBase
99

1010

11+
# 2026-10-20: Removed skip marker, test just works (#1544)
1112
@pytest.mark.production_server
12-
@pytest.mark.xfail(reason="failures_issue_1544", strict=False)
1313
def test_get_study_old():
1414
study = openml.study.get_study(34)
1515
assert len(study.data) == 105

‎tests/test_tasks/test_task_functions.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ def test__get_estimation_procedure_list(self):
5454
assert isinstance(estimation_procedures[0], dict)
5555
assert estimation_procedures[0]["task_type_id"] == TaskType.SUPERVISED_CLASSIFICATION
5656

57+
# 2026-10-20: Removed skip marker, test just works (#1544)
5758
@pytest.mark.production_server
58-
@pytest.mark.xfail(reason="failures_issue_1544", strict=False)
5959
def test_list_clustering_task(self):
6060
self.use_production_server()
6161
# as shown by #383, clustering tasks can give list/dict casting problems

0 commit comments

Comments
 (0)