Repository navigation
Conversation
ZEND_VM_ENTER_BIT tags the opline returned by CALL VM handlers. It is 1ULL so that ~ZEND_VM_ENTER_BIT keeps the upper half of 64-bit pointers, but on 32-bit platforms it widens the tagged pointer expressions to 64 bits, and casting those back to a pointer warns. This breaks --enable-werror builds where no global VM registers are used, e.g. arm32, or i386 with --disable-gcc-global-regs. Use (uintptr_t)1 instead, which is exactly pointer-sized everywhere, also in the copies of the definition in the JIT and the fuzzer SAPI.
Member
|
the fix looks correct to me, two things:
|
marc-mabe
force-pushed
the
fix/zend-vm-enter-bit
branch
from
October 17, 2026 11:11
a630057 to
c88bd36
Compare
Contributor
Author
|
@devnexen You are right, I forgot the fuzzer - it's fixed now as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZEND_VM_ENTER_BIT tags the opline returned by CALL VM handlers. It is 1ULL so that ~ZEND_VM_ENTER_BIT keeps the upper half of 64-bit pointers, but on 32-bit platforms it widens the tagged pointer expressions to 64 bits, and casting those back to a pointer warns. This breaks --enable-werror builds where no global VM registers are used, e.g. arm32, or i386 with --disable-gcc-global-regs, which also hits the copy of the definition in the JIT.
Use (uintptr_t)1 instead, which is exactly pointer-sized everywhere.