Skip to content

Commit 5e12b39

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Use umbrella instead of a direct include in timing module (#58540)
Summary: Pull Request resolved: #58540 Changelog: [Internal] Update the timing module to use `React/Debug.h` umbrella include instead of a direct one. Reviewed By: cipolleschi Differential Revision: D120137164 fbshipit-source-id: e6bf6a8b0b8b6684cb9ede64d4daef85879908b6
1 parent 63a199f commit 5e12b39

5 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎packages/react-native/Package.swift‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,8 @@ let reactFeatureFlags = RNTarget(
136136
let reactPerfLogger = RNTarget(
137137
name: .reactPerfLogger,
138138
path: "ReactCommon/reactperflogger",
139-
excludedPaths: ["fusebox"]
139+
excludedPaths: ["fusebox"],
140+
dependencies: [.reactDebug, .reactNativeDependencies]
140141
)
141142

142143
/// React-logger.podspec

‎packages/react-native/ReactCommon/jserrorhandler/CMakeLists.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ target_link_libraries(jserrorhandler
2222
folly_runtime
2323
${mapbufferjni}
2424
react_cxxstableapi
25+
react_debug
2526
react_featureflags
2627
)
2728
target_compile_reactnative_options(jserrorhandler PRIVATE)

‎packages/react-native/ReactCommon/jsitooling/CMakeLists.txt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ target_link_libraries(jsitooling
2121
folly_runtime
2222
glog
2323
jsi
24-
react_cxxstableapi)
24+
react_cxxstableapi
25+
react_timing)
2526

2627
target_compile_reactnative_options(jsitooling PRIVATE)
2728
target_compile_options(jsitooling PRIVATE -Wpedantic)

‎packages/react-native/ReactCommon/react/timing/primitives.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
#include <react/cxxstableapi/UmbrellaGuard.h>
1111

12-
#include <react/debug/flags.h>
12+
#include <React/Debug.h>
1313
#include <chrono>
1414
#include <cmath>
1515
#include <functional>

‎packages/react-native/scripts/cocoapods/utils.rb‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ def self.update_search_paths(installer)
424424
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-featureflags", "React_featureflags", []))
425425
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-renderercss", "React_renderercss", []))
426426
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-cxxstableapi", "React_cxxstableapi", []))
427+
.concat(ReactNativePodsUtils.create_header_search_path_for_frameworks("PODS_CONFIGURATION_BUILD_DIR", "React-debug", "React_debug", []))
427428
.each{ |search_path|
428429
header_search_paths = self.add_search_path_if_not_included(header_search_paths, search_path)
429430
}

0 commit comments

Comments
 (0)