From 46f3a3815c9ce02e24f786e425082aa26445edd2 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Fri, 9 Oct 2026 01:09:21 -0700 Subject: [PATCH] Remove componentNameByReactViewName from public API (#58771) Summary: Changelog: [Internal] Changes guard for `componentNameByReactViewName.h` to private and removes it from public umbrella. Comment in its implementation file says ``` // We need this function only for the transition period; // eventually, all names will be unified. ``` which strongly suggests it shouldn't be part of the public API. Reviewed By: cortinico Differential Revision: D122570794 --- .../renderer/componentregistry/componentNameByReactViewName.h | 2 +- scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.h b/packages/react-native/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.h index 8b3702c689af..a5371eea7793 100644 --- a/packages/react-native/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.h +++ b/packages/react-native/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.h @@ -7,7 +7,7 @@ #pragma once -#include +#include #include diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api index c43062b40357..89c55f7902e5 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api @@ -785,7 +785,6 @@ std::optional facebook::react::filterTypeFromString std::optional facebook::react::optionalFloatFromYogaValue(const facebook::yoga::Style::Length& length, std::optional base = {}); std::optional facebook::react::fontVariantFromCSSFontVariant(facebook::react::CSSFontVariant cssVariant); std::optional facebook::react::isolationFromString(std::string_view isolationSetting); -std::string facebook::react::componentNameByReactViewName(std::string viewName); std::string facebook::react::toString(const double& value); std::string facebook::react::toString(const facebook::react::AccessibilityRole& accessibilityRole); std::string facebook::react::toString(const facebook::react::AttributedString::Range& range); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api index a3bfd7f91a8a..bf96a008e34c 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api @@ -3584,7 +3584,6 @@ std::optional facebook::react::filterTypeFromString std::optional facebook::react::optionalFloatFromYogaValue(const facebook::yoga::Style::Length& length, std::optional base = {}); std::optional facebook::react::fontVariantFromCSSFontVariant(facebook::react::CSSFontVariant cssVariant); std::optional facebook::react::isolationFromString(std::string_view isolationSetting); -std::string facebook::react::componentNameByReactViewName(std::string viewName); std::string facebook::react::toString(const double& value); std::string facebook::react::toString(const facebook::react::AccessibilityRole& accessibilityRole); std::string facebook::react::toString(const facebook::react::AttributedString::Range& range); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api index cb763baece52..927b6540c559 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api @@ -360,7 +360,6 @@ std::optional facebook::react::blendModeFromString(s std::optional facebook::react::filterTypeFromString(std::string_view filterName); std::optional facebook::react::fontVariantFromCSSFontVariant(facebook::react::CSSFontVariant cssVariant); std::optional facebook::react::isolationFromString(std::string_view isolationSetting); -std::string facebook::react::componentNameByReactViewName(std::string viewName); std::string facebook::react::toString(const double& value); std::string facebook::react::toString(const facebook::react::AccessibilityRole& accessibilityRole); std::string facebook::react::toString(const facebook::react::AttributedString::Range& range);