From 99d8fc241b84321be4e0d707ff35c218b4c116bd Mon Sep 17 00:00:00 2001 From: Michal Faferek Date: Thu, 19 Nov 2026 16:56:36 +0100 Subject: [PATCH] fix(gateway): record all topics in the bringup preset A fault that comes through a bridge was recorded with the bridge's own topics only, so a /diagnostics fault got a bag with /diagnostics and nothing about the robot. The preset now sets snapshots.rosbag.topics to "all". Sensor topics stay excluded. --- src/ros2_medkit_gateway/config/bringup_params.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/ros2_medkit_gateway/config/bringup_params.yaml b/src/ros2_medkit_gateway/config/bringup_params.yaml index da736fbff..2954ea319 100644 --- a/src/ros2_medkit_gateway/config/bringup_params.yaml +++ b/src/ros2_medkit_gateway/config/bringup_params.yaml @@ -23,10 +23,16 @@ fault_manager: healing_enabled: true healing_threshold: 0 - # Black-box rosbag capture: a crash-safe, entity-scoped ring buffer flushed on - # fault confirmation. Produces a non-empty bag on the happy path. + # Black-box rosbag capture: a crash-safe ring buffer flushed on fault confirmation. snapshots.rosbag.enabled: true + # "all", not the parameter default of "entity": this preset runs without a + # manifest, and its faults come from the bridges. "entity" writes the topics + # of the node that reported the fault, which for a bridged fault is the + # bridge itself, so a /diagnostics fault gets a bag with /diagnostics only. + # Image and point cloud topics stay out (snapshots.rosbag.exclude_sensor_topics). + snapshots.rosbag.topics: all + # The bridges run with their own config/.yaml defaults; they are toggled # on/off with the enable_* launch args. Tune their runtime cost in those configs # or via each bridge's launch args (see the bringup quickstart):