Skip to content

Clicking the Add Alert Icon on a Dashboard Tile does not open the modal with the alert editor #1781

Open

Description

@MikeShi42
  1. Go to dashboard
  2. Click "Add Alert" icon on a dashboard tile
  3. modal opens - but it does not open with the add alert editor section already open.

The user still needs to click "Add Alert" in the chart editor modal, but it should already be open.

Activity

  1. MikeShi42 commented on Feb 23, 2026

    @MikeShi42
    ContributorAuthor

    @claude please start working on a fix

  2. claude commented on Feb 23, 2026

    @claude

    Claude finished @MikeShi42's task in 6m 24s —— View job • claude/issue-1781-20260223-2123 • Create PR ➔


    Fixing: Add Alert icon should open modal with alert editor pre-opened

    • Gather context and explore codebase
    • Understand the request and identify fix location
    • Implement the fix
      • DBDashboardPage.tsx: Add openAlertEditor state, pass onAddAlertClick to Tile, update EditTileModal
      • Tile component: Use onAddAlertClick for bell icon click
      • EditTileModal: Accept and pass openAlertEditor prop
      • EditTimeChartForm: Accept openAlertEditor prop and auto-enable alert on mount
    • Commit and push

    Summary

    Root cause: Clicking the bell icon on a dashboard tile called onEditClick() (same as the pencil edit button), with no information that the alert section should be pre-opened.

    Fix: Threaded an openAlertEditor flag from the bell icon click down to the chart editor form:

    1. Tile component — The onAddAlertClick prop (already in the type definition) is now destructured and used as the onClick handler for the bell icon instead of onEditClick.

    2. DBDashboardPage — Added openAlertEditor state. When onAddAlertClick fires, both editedTile and openAlertEditor=true are set. The flag is passed to EditTileModal and reset on close/save.

    3. EditTileModal — Accepts and forwards openAlertEditor to EditTimeChartForm.

    4. EditTimeChartForm — Accepts openAlertEditor prop. On mount, if openAlertEditor is true and no alert exists yet, the alert field is initialized to DEFAULT_TILE_ALERT, making the alert editor section immediately visible.

  3. added a commit that references this issue on Feb 23, 2026
    f4c44ef
  4. gedaliakliger commented on Nov 16, 2026

    @gedaliakliger

    I'm taking this one: the tile's alert button will open the editor with the alert panel showing, on the tile's alert or on a new draft. #3194 fixed it before the alert panel landed and was closed by the open-PR limit; I'll credit it in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions