You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Clicking the Add Alert Icon on a Dashboard Tile does not open the modal with the alert editor #1781
Fixing: Add Alert icon should open modal with alert editor pre-opened
Gather context and explore codebase
Understand the request and identify fix location
Implement the fix
DBDashboardPage.tsx: Add openAlertEditor state, pass onAddAlertClick to Tile, update EditTileModal
Tile component: Use onAddAlertClick for bell icon click
EditTileModal: Accept and pass openAlertEditor prop
EditTimeChartForm: Accept openAlertEditor prop and auto-enable alert on mount
Commit and push
Summary
Root cause: Clicking the bell icon on a dashboard tile called onEditClick() (same as the pencil edit button), with no information that the alert section should be pre-opened.
Fix: Threaded an openAlertEditor flag from the bell icon click down to the chart editor form:
Tile component — The onAddAlertClick prop (already in the type definition) is now destructured and used as the onClick handler for the bell icon instead of onEditClick.
DBDashboardPage — Added openAlertEditor state. When onAddAlertClick fires, both editedTile and openAlertEditor=true are set. The flag is passed to EditTileModal and reset on close/save.
EditTileModal — Accepts and forwards openAlertEditor to EditTimeChartForm.
EditTimeChartForm — Accepts openAlertEditor prop. On mount, if openAlertEditor is true and no alert exists yet, the alert field is initialized to DEFAULT_TILE_ALERT, making the alert editor section immediately visible.
I'm taking this one: the tile's alert button will open the editor with the alert panel showing, on the tile's alert or on a new draft. #3194 fixed it before the alert panel landed and was closed by the open-PR limit; I'll credit it in the PR.
Activity
MikeShi42 commentedon Feb 23, 2026
@claude please start working on a fix
claude commentedon Feb 23, 2026
Claude finished @MikeShi42's task in 6m 24s —— View job •
claude/issue-1781-20260223-2123• Create PR ➔Fixing: Add Alert icon should open modal with alert editor pre-opened
DBDashboardPage.tsx: AddopenAlertEditorstate, passonAddAlertClicktoTile, updateEditTileModalTilecomponent: UseonAddAlertClickfor bell icon clickEditTileModal: Accept and passopenAlertEditorpropEditTimeChartForm: AcceptopenAlertEditorprop and auto-enable alert on mountSummary
Root cause: Clicking the bell icon on a dashboard tile called
onEditClick()(same as the pencil edit button), with no information that the alert section should be pre-opened.Fix: Threaded an
openAlertEditorflag from the bell icon click down to the chart editor form:Tilecomponent — TheonAddAlertClickprop (already in the type definition) is now destructured and used as theonClickhandler for the bell icon instead ofonEditClick.DBDashboardPage— AddedopenAlertEditorstate. WhenonAddAlertClickfires, botheditedTileandopenAlertEditor=trueare set. The flag is passed toEditTileModaland reset on close/save.EditTileModal— Accepts and forwardsopenAlertEditortoEditTimeChartForm.EditTimeChartForm— AcceptsopenAlertEditorprop. On mount, ifopenAlertEditoris true and no alert exists yet, the alert field is initialized toDEFAULT_TILE_ALERT, making the alert editor section immediately visible.fix: open alert editor when clicking Add Alert icon on dashboard tile
gedaliakliger commentedon Nov 16, 2026
I'm taking this one: the tile's alert button will open the editor with the alert panel showing, on the tile's alert or on a new draft. #3194 fixed it before the alert panel landed and was closed by the open-PR limit; I'll credit it in the PR.