Repository navigation
fix(common-utils): preserve boolean grouping for mixed AND/OR searches #3690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tyagiquamar
wants to merge
1
commit into
ClickHouse:main
Choose a base branch
from
Tyagiquamar:agent/fix-mixed-operator-precedence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@hyperdx/common-utils': patch | ||
| --- | ||
|
|
||
| fix: preserve boolean grouping when a search mixes AND and OR without explicit | ||
| parentheses, so generated SQL no longer regroups the query as `(a AND b) OR c` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 major — Mixed chains with negated operators are still regrouped:
a AND NOT b OR ckeeps the bug this PR fixesThe lucene grammar parses
AND NOT/OR NOT/NOTas single operators and right-nests them the same way it doesAND/OR. Soa AND NOT b OR cparses asAND NOT(a, OR(b, c)). Because of the!negatingOperatorexclusion, the serializer still emitsa AND NOT b OR c, which ClickHouse evaluates as(a AND NOT b) OR c. That is wrong: it should bea AND NOT (b OR c). Results for this query are still silently wrong, and it now behaves differently froma AND b OR c, which the PR does group. Fix: drop thenegatingOperatorexclusion so the OR operand is wrapped (NOT (b OR c)), or narrow it to a case the AST actually needs. Add tests fora AND NOT b OR c,a NOT b OR canda OR NOT b AND calongside the newmixed operator precedencecases. The current tests only cover AND/OR, so they would pass with this regression in place.Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond