Repository navigation
feat(fifo): warn when the runner ack times out - #34
Merged
Merged
Conversation
A missing ack from the runner previously surfaced only as an AckTimeout error, with nothing in the logs to explain it. Log a warning with the timeout that elapsed, then propagate the error unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
lvaroqui
force-pushed
the
feat/warn-on-ack-timeout
branch
from
October 16, 2026 09:33
02dacbd to
da32d6e
Compare
lvaroqui
marked this pull request as ready for review
October 16, 2026 09:39
 [Medium impact] This PR appears safe to merge. SummaryAdds a warning when
No actionable issues found. Tests were not run. Reviews (1) · Last reviewed commit: "feat(fifo): warn when the runner ack tim..." · Reviewed by Greptile |
not-matthias
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log a warning when
waitForAckgives up waiting for the runner's ack.Previously a missing ack only surfaced as an
AckTimeouterror, which integrations usually map to a generic failure status, so nothing in the output explained what went wrong. The warning includes the timeout that elapsed (default 1000ms):The error is still propagated unchanged, so callers see no behavior change beyond the log line.