Skip to content

London | No Cohort | Daniel Wagner-Hall | Sprint 3 | Quote Generator #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
illicitestonion wants to merge 3 commits into from
Closed

London | No Cohort | Daniel Wagner-Hall | Sprint 3 | Quote Generator #1477

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4354165
Implement quote generator
illicitonion Oct 8, 2026
d18e2b0
Extract function to avoid duplication
illicitonion Oct 8, 2026
b7fd2a7
Don't wrap in functions
illicitonion Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
const showNewQuote = () => {
const {quote, author} = pickFromArray(quotes);
document.getElementById("quote").innerText = quote;
document.getElementById("author").innerText = author;
};

document.addEventListener("DOMContentLoaded", showNewQuote);

document.querySelector("button").addEventListener("click", showNewQuote);

Comment on lines +1 to +10

@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot Oct 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t see any trainee-written comments in this change set, only code. Since the functions and event listeners here are already quite clear (showNewQuote and the click handler are self-explanatory), this is a nice example of code that doesn’t need extra comments at all. As you keep working, you might ask yourself: whenever you feel the urge to add a comment, is there a way to make the code or naming so clear that the comment becomes unnecessary? That habit will keep your codebase easier to read and maintain.

To "like" or "dislike" this comment, please follow this link

// DO NOT EDIT BELOW HERE

// pickFromArray is a function which will return one item, at
Expand Down
Loading