Repository navigation
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Alaterry8
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Alaterry8
changed the title
This comment has been minimized.
This comment has been minimized.
Alaterry8
changed the title
Alaterry8
added
the
Needs Review
Liam310
added
Review in progress
Liam310
reviewed
Sep 15, 2026
Liam310
reviewed
Sep 15, 2026
Liam310
reviewed
Sep 15, 2026
Contributor
|
Hey @Alaterry8! You've showcased a good understanding of some appropriate choices for form elements here along with a good start with validating the inputs. As it stands, there are still a couple of inputs that are considered valid when they shouldn't be. Have a read of comments and see what you think! |
Liam310
added
Reviewed
Alaterry8
added
Needs Review
Author
|
Hey @Liam310, apologies for the delay, just got around to adding the last bits, do let me know if any further changes are needed. Thanks! |
Liam310
reviewed
Oct 6, 2026
Comment on lines
+21
to
+22
| minlength="2" | ||
| pattern="[A-Za-z]+" |
Contributor
There was a problem hiding this comment.
pattern is the correct attribute to use here, but this is not the right pattern. Have a read of the instructions again and you'll find what you're looking for!
Liam310
added
Reviewed
Contributor
|
@Alaterry8 Just a small change to make! |
Alaterry8
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task ID: CYF-1004
Changelist
I agree to follow the code of conduct for this organisation.