Repository navigation
Conversation
Contributor
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This was referenced Nov 19, 2026
Draft
dougqh
force-pushed
the
dougqh/ffe-toolbox-shading
branch
from
November 19, 2026 21:24
3d4204f to
8dd30e7
Compare
dougqh
force-pushed
the
dougqh/ffe-exposure-cache
branch
from
November 19, 2026 21:24
dc0a80f to
af61b74
Compare
dougqh
force-pushed
the
dougqh/ffe-toolbox-shading
branch
from
November 19, 2026 22:38
8dd30e7 to
cdda826
Compare
dougqh
force-pushed
the
dougqh/ffe-exposure-cache
branch
from
November 19, 2026 22:41
af61b74 to
741cd7d
Compare
This was referenced Nov 19, 2026
dougqh
force-pushed
the
dougqh/ffe-exposure-cache
branch
from
November 20, 2026 13:36
741cd7d to
53bec3c
Compare
dougqh
force-pushed
the
dougqh/ffe-toolbox-shading
branch
from
November 20, 2026 13:39
89895cd to
8c81722
Compare
dougqh
force-pushed
the
dougqh/ffe-exposure-cache
branch
from
November 20, 2026 13:39
53bec3c to
17e1eaa
Compare
LLM ValidationLLM Validation Gate — java-agent-instructions✅ PASS
6 case(s) · quality 81.1 → 81.4 (+0.3) · win-rate 50% [47%–53%] Details — analysis and per-case resultsAnalysisChanged instruction file(s): No safety or blocking-case regressions across 6 case(s). Overall pairwise win-rate 50% [47%–53%], quality +0.3 — see the verdict above for whether that clears the noise band. Results
Cases
Per-dimension scores, token usage, latency, and estimated cost are in the CI job logs. |
dougqh
force-pushed
the
dougqh/ffe-toolbox-shading
branch
from
November 20, 2026 20:50
8c81722 to
6ac4db5
Compare
dougqh
force-pushed
the
dougqh/ffe-exposure-cache
branch
from
November 20, 2026 20:50
17e1eaa to
53df754
Compare
dougqh
force-pushed
the
dougqh/ffe-toolbox-shading
branch
from
November 20, 2026 21:32
6ac4db5 to
0e0d85e
Compare
dougqh
force-pushed
the
dougqh/ffe-exposure-cache
branch
from
November 20, 2026 21:32
53df754 to
a9c8f34
Compare
One entry per subject, keyed by flag and subject without a key object, updated in place and linked in LRU order: a lookup allocates nothing, and a full cache holds one object per subject instead of three. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: dougqh <dougqh@gmail.com>
At full capacity its bucket array is 512 KiB, a humongous allocation on a small G1 heap, which a client that records no exposures should not pay for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dougqh
force-pushed
the
dougqh/ffe-toolbox-shading
branch
from
November 21, 2026 03:53
0e0d85e to
676974d
Compare
dougqh
force-pushed
the
dougqh/ffe-exposure-cache
branch
from
November 21, 2026 03:53
a9c8f34 to
8064973
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Moves
ExposureDeduplicationCachefrom an access-orderedLinkedHashMaponto the toolbox'sHashtable.D2, keyed by flag and subject:Exposure) holds both keys, the last allocation, variant and serial id, and its links in the least-recently-used order. Before, each subject cost aLinkedHashMapentry, aKeyand aSent.containsandrecordIfChangedlook up by the two strings without a key object, andrecordIfChangedupdates the entry in place when the exposure changes. Before, each call built aKey, aSentand the varargs array ofObjects.hash.Motivation
The cache is long-lived: once a service has seen 65,536 subjects, it stays full. Every object it holds is old-generation state that each marking cycle has to walk. Per subject, with compressed oops:
LinkedHashMapentry (40 B),Key(24 B),Sent(24 B)Exposure(56 B)Key,Sent, anObject[2]The "after" sizes come from a class histogram at the end of a benchmark run: 65,536
Exposureinstances, 3,670,016 B. The "before" sizes are computed from the field layouts. The bucket array has 131,072 slots either way.Measured on its own by Bits: this PR's head before the review follow-ups (
af61b74853) against #13532's head (8dd30e7901). Both sides get the same benchmark-only overlay (#13529'sClientEvaluationBenchmarkand aconsentparam). Unique subjects, JDK 21.0.12,-prof gc; base, #13533, #13534 and #13535 forks rotate fork by fork, so those PRs share the base runs. "Noise" means the fork ranges overlap.Retained size of a full cache (65,536 entries, JOL):
256 MB heap, average time (5 forks at 1 thread, 3 at 4 threads):
scale/flagsscale/flagsscale/splitsscale/splits128 MB heap, G1, 4 threads, throughput (3 forks; per million evaluations, whole fork from the GC logs):
scale/flagsscale/splitsscale/splits: −17% GC ms per million evaluations at 1 thread, and −10% pause on the small heap.Additional Notes
Hashtableclasses.ExposureDeduplicationCacheTestpasses unchanged, including the LRU tests. The coverage exclusions forKeyandSentare removed with those classes.dd-openfeaturetests pass, and Spotless, SpotBugs (spotbugsMain,spotbugsTest,spotbugsJmh) andcheckToolboxRelocationpass. The sandbox run on the earlier base had 1,609 tests: Benchmark FFE evaluation on the scale suites #13485 adds the scale-suite tests.ConcurrentHashtable, socontainsreads without the lock. With 4 threads, JFR showed 61 contended enters (86 ms) on this cache's lock in 11 s, and every hit rewrites up to 6 link fields.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Review follow-ups
Hashtable.D2table is created on the first recorded exposure. At full capacity its bucket array is 512 KiB, a humongous allocation on a small G1 heap, which a client that records no exposures no longer pays for.🤖 Generated with Claude Code