Repository navigation
Turn off remote config by default in AWS Lambda - #13590
joeyzhao2018 wants to merge 1 commit into
Conversation
The Datadog Lambda extension serves no Remote Configuration: its /info endpoint doesn't list /v0.7/config, so the poller can never receive a configuration there. dd-trace-js and dd-trace-py already turn it off in Lambda. When AWS_LAMBDA_FUNCTION_NAME is set, both the startup check in Agent and Config now default Remote Configuration to off. Setting DD_REMOTE_CONFIGURATION_ENABLED or the legacy DD_REMOTE_CONFIG_ENABLED to true still turns it on. Nothing changes outside Lambda. The Lambda wrapper already sets the legacy DD_REMOTE_CONFIG_ENABLED=false for Java. Config honoured it, but the startup check ignored it, so AppSec still started in inactive mode. The check now honours it in Lambda. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The completed static review found no reportable defect in Lambda’s default-off behavior or explicit opt-in handling. No human PR discussion supplied additional concerns.
🤖 Bits Code Review · Commit 08ec091
What Does This Do
In AWS Lambda, Remote Configuration is now off by default. It stays on only when
DD_REMOTE_CONFIGURATION_ENABLED(or the legacyDD_REMOTE_CONFIG_ENABLED) is set totrue. Nothing changes outside Lambda.With Remote Configuration off, a Lambda function no longer starts the Remote Configuration poller. It also no longer starts AppSec in its inactive mode, where AppSec waits for Remote Configuration to activate it. Functions that set
DD_APPSEC_ENABLED=truestill start AppSec as before.Motivation
The Datadog Lambda extension doesn't serve Remote Configuration: its
/infoendpoint doesn't list/v0.7/config. The poller can never receive a configuration in Lambda. It still wakes every 5 seconds while the function runs, and re-checks/infoat most once a minute. The public docs list Lambda as unsupported, and dd-trace-js and dd-trace-py already turn Remote Configuration off there.Most Java functions already intend to turn it off. Since DataDog/datadog-lambda-extension#117, the Lambda wrapper (
AWS_LAMBDA_EXEC_WRAPPER=/opt/datadog_wrapper) exportsDD_REMOTE_CONFIG_ENABLED=falsefor Java. #6642 later renamed the setting toDD_REMOTE_CONFIGURATION_ENABLEDand kept the old name as an alias.Confighonours that alias, so the poller doesn't start. But the startup check that decides whether AppSec starts ORs the two names, and the new name defaults totrue. That check ignores the wrapper's setting, so AppSec still starts in inactive mode. Functions that don't use the wrapper keep Remote Configuration fully on.Additional Notes
AgentandConfig. Both detect Lambda fromAWS_LAMBDA_FUNCTION_NAME, as the existing Lambda checks do (profiling,Config.isAwsServerless()).DD_TRACE_CONFIGproperties file isn't enough on its own, because the startup check doesn't read it. This is the same as for the other features that are off by default, such as profiling.DD_REMOTE_CONFIGURATION_ENABLED=falsealone doesn't stop AppSec from starting in inactive mode. Fixing that changes AppSec startup for every service, not just Lambda functions.🤖 Generated with Claude Code