Skip to content

fix: Show Battle Animation in Combat on hero in 2k3, an ally target is a hero ID and not a battler position #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oulianov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Show Battle Animation in Combat on hero in 2k3, an ally target is a hero ID and not a battler position #3696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/game_interpreter_battle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,10 +496,12 @@ bool Game_Interpreter_Battle::CommandShowBattleAnimation(lcf::rpg::EventCommand
Game_Battler* battler_target = nullptr;

if (allies) {
// Allies counted from 1
target -= 1;
if (target >= 0 && target < Main_Data::game_party->GetBattlerCount()) {
battler_target = &(*Main_Data::game_party)[target];
// RPG_RT: The target is the ID of a hero (RPG Maker 2003 lists the heroes of the database),
// the animation is only shown when the hero is in the party
for (auto* actor: Main_Data::game_party->GetActors()) {
if (actor->GetId() == target) {
battler_target = actor;
}
}
}
else {
Expand Down
Loading