fix: scope dev server metadata to Ruby mode (#632) - #633
Merged
Merged
Conversation
Keep development and test servers from sharing a metadata file, and verify the recorded port before proxying. Require the corresponding vite-plugin-ruby patch so the Ruby reader and Vite writer use the same path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
Fixes #632. A running development server no longer causes local test requests to proxy to an empty test port.
Background 📜
Ruby previously treated the existence of the shared
tmp/vite-ruby.jsonas evidence that the current mode’s dev server was running. The Vite plugin wrote that file regardless of mode.The Fix 🔨
tmp/vite-ruby-<mode>.jsonusing the resolved Ruby mode; check the recorded port against the Ruby config before proxying.vite-plugin-ruby@^5.2.5fromvite_ruby.