Skip to content

Fix pssolar tests failing on last-command exit status #9239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Esteban82 merged 2 commits into from
Oct 1, 2026
Merged

Fix pssolar tests failing on last-command exit status #9239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdbf3c8
Fix pssolar tests failing on last-command exit status
Esteban82 Oct 1, 2026
11390e0
Merge branch 'master' into fix-pssolar-test-exit
Esteban82 Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/pssolar/pssolar_missing_plusd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ gmt solar -Td+d2020-01-01T00:00:00 -M > jan.txt 2>fail_jan
gmt solar -Td+d2020-06-01T00:00:00 -M > jun.txt 2>fail_jun
[ -s fail_jan ] && cat fail_jan >> fail
[ -s fail_jun ] && cat fail_jun >> fail
diff jan.txt jun.txt > /dev/null && echo "Jan and Jun terminators are identical - date is being ignored" >> fail
if diff jan.txt jun.txt > /dev/null; then echo "Jan and Jun terminators are identical - date is being ignored" >> fail; fi
2 changes: 1 addition & 1 deletion test/pssolar/pssolar_tz.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ while read tz minutes; do
'{got = $1 * 1440 - 720 + $2; if (got - m > 1e-4 || m - got > 1e-4) printf "+z%s gave %.6f minutes, expected %s\n", tz, got, m}'
done < tz.txt > fail

gmt solar -I0/0+zabc -C > /dev/null 2>&1 && echo "+zabc was accepted" >> fail
if gmt solar -I0/0+zabc -C > /dev/null 2>&1; then echo "+zabc was accepted" >> fail; fi
Loading