Repository navigation
fix: don't import axios into RN SDK - #3853
Merged
Merged
Conversation
Contributor
SDK Size
|
isekovanic
approved these changes
Oct 12, 2026
szuperaz
added a commit
to GetStream/stream-chat-js
that referenced
this pull request
Oct 13, 2026
…1909) https://linear.app/stream/issue/REACT-1225/ensure-stream-chat-js-parses-api-error-correctly-if-multiple-axios Noticed this while I was checking [duplicate message id handling](#1907) in v10. In RN SampleApp, this doesn't work correctly because SampleApp has two copies of axios: - One from `stream-chat` installed by SampleApp - One from the SDK's `stream-chat` copy - When RN calls `installNativeMultipartAdapter,` it replaces SampleApp's axios adapter with the RN SDK's adapter copy and `error instanceof AxiosError` will always return `false`, which meant errors weren't parsed properly - The root cause is that RN shouldn't import from `axios`, fixed here: GetStream/stream-chat-react-native#3853 - Still, this fix makes sense regardless of RN fixed, stream-chat-js is updated to do a more robust `isAxiosError(error)` check, instead of relying on `instanceof`
isekovanic
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/stream/issue/REACT-1225/ensure-stream-chat-js-parses-api-error-correctly-if-multiple-axios
Avoid importing
axiosfrom RN SDK. It can cause duplicate copies of Axios.