Repository navigation
refactor: separate thread from channel hoc - #3867
Open
isekovanic wants to merge 5 commits into
Open
isekovanic wants to merge 5 commits into
isekovanic wants to merge 5 commits into
Conversation
isekovanic
requested review from
oliverlaz,
santhoshvai and
szuperaz
and removed request for
santhoshvai
October 17, 2026 15:41
Contributor
SDK Size
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR separates the
ThreadHOC from theChannelone hierarchically.<Thread thread={thread}>now renders next to<Channel>instead of inside it. This removes theif (threadList) ... else ...branching across the SDK and stops opening a thread from running the channel's open sequence, which marked the channel read.Stacked on
perf/message-actions.🛠 Implementation details
<Channel>and<Thread>share a new internalChannelShell(providers and config props), and each owns only its own lifecycle.<Thread>providesThreadContext;useThreadContext()no longer throws and returns{ thread: undefined }outside a thread.Breaking changes
<Channel>losesthreadandthreadList.<Thread>renderschildren,threadis required, and the old list/composer props are removed (parentMessagePreventPressmoves toThreadFooterComponent).ThreadMessageComposerslot is removed.threadListis removed everywhere. UseuseThreadContext().thread.ThreadContextValueis{ thread?, allowThreadMessagesInChannel }, andonAlsoSentToChannelHeaderPressmoved toMessagesContext.Fixes
🎨 UI Changes
/
🧪 Testing
/
☑️ Checklist
developbranch