Skip to content

chore(video-intelligence): update package dependencies - #4422

Merged
angelcaamal merged 6 commits into
mainfrom
chore/update-video-intelligence-samples-package
Oct 22, 2026
Merged

angelcaamal merged 6 commits into
mainfrom
chore/update-video-intelligence-samples-package

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR skips the system tests for the Google Cloud Video Intelligence API.

Reason for Changes

  • Missing Resources: The underlying test files and cloud resources (such as sample videos and buckets) are no longer available in the test environment, causing frequent CI failures.
  • API Lifecycle: The Video Intelligence API is deprecated/no longer receiving updates, so these system tests are being retired to keep the CI pipelines green and stable.

Fixes Internal: b/553467107

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: videointelligence Issues related to the Video Intelligence API API. samples Issues that are directly related to samples. labels Aug 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine requirement to >=20.0.0 and upgrades several dependencies in video-intelligence/package.json, including @google-cloud/video-intelligence, c8, and chai. Feedback was provided to revert the chai upgrade to ^4.5.0, as upgrading to v6.0.0 will cause test failures due to ESM-only compatibility issues in a CommonJS project.

Comment thread video-intelligence/package.json
@angelcaamal angelcaamal added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2026
@angelcaamal angelcaamal removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 21, 2026

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal
angelcaamal marked this pull request as ready for review October 22, 2026 21:27
@angelcaamal
angelcaamal requested review from a team as code owners October 22, 2026 21:27

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal
angelcaamal merged commit 5471e90 into main Oct 22, 2026
21 checks passed
@angelcaamal
angelcaamal deleted the chore/update-video-intelligence-samples-package branch October 22, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: videointelligence Issues related to the Video Intelligence API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants