Repository navigation
Conversation
Cover cross-context and deleted programs, lost contexts, and valid empty or unknown uniform-name queries. Use the shared WebGL context helper and unbind the second program before deletion.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression coverage for getUniformIndices returning null for programs from another context, deleted programs, and lost contexts. Check both empty and non-empty name lists for cross-context programs, and verify the expected GL errors for cross-context and deleted programs.
Also check that valid calls still return an empty array for an empty name list and INVALID_INDEX for an unknown uniform name. Use the shared context creation helper and unbind the second program before deleting it so deletion is not deferred.
These tests cover the Chromium fix in https://chromium-review.googlesource.com/c/chromium/src/+/8424960 and are added to the existing WebGL test as requested in that review.
Validation:
macOS headless Chromium build: 37 PASS, 0 FAIL, including the context-loss test.
The initial Chrome run reproduced four failing null-return assertions; its valid-call and GL-error checks passed.
WebGL linter for conformance2/programs, inline JavaScript syntax check, and git diff --check passed.