Skip to content

Add getUniformIndices error return tests - #3794

Open
Yelihi wants to merge 1 commit into
KhronosGroup:mainfrom
Yelihi:get-uniform-indices-error-tests
Open

Yelihi wants to merge 1 commit into
KhronosGroup:mainfrom
Yelihi:get-uniform-indices-error-tests

Conversation

@Yelihi

@Yelihi Yelihi commented Sep 18, 2026

Copy link
Copy Markdown

Add regression coverage for getUniformIndices returning null for programs from another context, deleted programs, and lost contexts. Check both empty and non-empty name lists for cross-context programs, and verify the expected GL errors for cross-context and deleted programs.

Also check that valid calls still return an empty array for an empty name list and INVALID_INDEX for an unknown uniform name. Use the shared context creation helper and unbind the second program before deleting it so deletion is not deferred.

These tests cover the Chromium fix in https://chromium-review.googlesource.com/c/chromium/src/+/8424960 and are added to the existing WebGL test as requested in that review.

Validation:
macOS headless Chromium build: 37 PASS, 0 FAIL, including the context-loss test.
The initial Chrome run reproduced four failing null-return assertions; its valid-call and GL-error checks passed.
WebGL linter for conformance2/programs, inline JavaScript syntax check, and git diff --check passed.

Cover cross-context and deleted programs, lost contexts, and valid empty or unknown uniform-name queries. Use the shared WebGL context helper and unbind the second program before deletion.
@CLAassistant

CLAassistant commented Sep 18, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants