Repository navigation
Conversation
mgree
force-pushed
the
builtin-registry-agg-table-sql
branch
from
November 18, 2026 21:44
c9d83fe to
3a6b6bf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR 2 of SQL-923.
Description
The builtin registry now records every aggregate and table function variant alongside the scalar functions, so a change to their recorded properties (null handling, output types, monotonicity, WITH ORDINALITY support) fails the snapshot test. Variants are listed from their serde impls, so adding or removing one also fails it.
Unlike the scalar functions, we don't fingerprint the implementations of
AggregateFuncorTableFunc, because sound coverage would need a compiler-resolved call graph that isn't worth its cost. The newtable_func_inputs.sltruns every table function on edge-case inputs read from tables, so the functions actually execute instead of being constant-folded. In PR 3, we'll do some differential testing from sqllogictest.Verification
Rewrote the registry; new SLT passes (though we don't fingerprint).