Skip to content

catalog: add aggregate and table functions to the builtin registry - #40912

Open
mgree wants to merge 1 commit into
builtin-registryfrom
builtin-registry-agg-table-sql
Open

mgree wants to merge 1 commit into
builtin-registryfrom
builtin-registry-agg-table-sql

Conversation

@mgree

@mgree mgree commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

PR 2 of SQL-923.

Description

The builtin registry now records every aggregate and table function variant alongside the scalar functions, so a change to their recorded properties (null handling, output types, monotonicity, WITH ORDINALITY support) fails the snapshot test. Variants are listed from their serde impls, so adding or removing one also fails it.

Unlike the scalar functions, we don't fingerprint the implementations of AggregateFunc or TableFunc, because sound coverage would need a compiler-resolved call graph that isn't worth its cost. The new table_func_inputs.slt runs every table function on edge-case inputs read from tables, so the functions actually execute instead of being constant-folded. In PR 3, we'll do some differential testing from sqllogictest.

Verification

Rewrote the registry; new SLT passes (though we don't fingerprint).

@mgree
mgree marked this pull request as ready for review November 18, 2026 21:25
@mgree
mgree requested review from a team as code owners November 18, 2026 21:25
@mgree
mgree changed the base branch from main to builtin-registry November 18, 2026 21:27
@mgree
mgree added this pull request to stack #40921 November 18, 2026 21:28
@mgree
mgree force-pushed the builtin-registry-agg-table-sql branch from c9d83fe to 3a6b6bf Compare November 18, 2026 21:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant