Repository navigation
feat: add manifest concept to skeleton API for level of indirection in by ID fetching - #251
Merged
Merged
Conversation
This would allow future work to change from one full fragment per ID to many without needing to change the complete file layout
This is unsafe state manipulation being removed for this round of PR
Also includes a large refactor to clarify which parts are spatial specific and not. For example, a skeleton node is not spatial, so gets pulled out of that path. This rename causes a pretty large shift in the code and restructure. Should also more reliably hide parts of the skeleton tab content when only in readonly. While a big change, it should overall result in a clearer way forward for precomputed and less duplication and hopefully clearer boundaries.
Also require spatial to be coarsest to finest for simplicity
This allows them to be used in shaders, and also more easily allows to extend the list of known keys in the future and to support unknown or non-specially handled keys
Bounds have been introduced as part of the coordinateSpace metadata instead, so these second bounds were a duplicate and could be a source of error. Also allow confidence values to be optional, if not provided, we assume the datasource can store 0 - 100 and doesn't use discrete bins for confidence
…mputed feat, refactor: skeleton tab for precomputed skeletons
Previously the concept of being directed was not clear, and there were two ways to indicate edges which then had to be resolved. Now a fragment source indicates if it is directed, and gives the edges
seankmartin
added this pull request to stack #259
October 19, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow future work to change from one full fragment per ID to many without
needing to change the complete file layout. Additional summary of what tried to do with core API with aim to have
skeleton/api.tspretty much final for this PR:Catmaid still has one fragment and one fetch.
options and also with existing concepts.
attributes, and leave the rest as normal. Allows hooking these into the shader at a later date but that part not
done yet as focus is on the API structure. Description remains separate as it is a string.
datasource part itself.
As a way to stress test this API, it adds support for precomputed skeletons in the skeleton browser