Repository navigation
refactor: reduce core changes - #261
Draft
seankmartin wants to merge 7 commits into
Draft
seankmartin wants to merge 7 commits into
seankmartin wants to merge 7 commits into
Conversation
The responsibilities of the index file were getting a bit muddled and the size had increased substantially. Instead aimed to keep the index file about the core integration. It handles holding important state objects, forming attachments between different objects, passing relevant state, holding key layers and core options. Details relating to selection are moved to selection.ts and made only one owner of the selected node. ui concerns to /ui, mainly around selection details and sharing node icons and labels Skeleton source connection links a layer and a skeleton source to share context for edit commands, edit actions, and the find path tool. We also reduce the changes dependent_view_widget.ts against master, as we still need a way to stop rebuilding while setting node properties, but have a lighter weight solution this time around Finally we nest the skeleton browse options in the state under a new key Also fixes the preview ID, so the selection details dont' show it, when selecting either a node or segID
Was using wrong pattern previously for binding commands to the viewer
These will just go out of sync
The skeleton files had expanded quite dramatically at the base for new concepts that were spatial skeleton only, or edit path only. This aims to clearly separate these concepts out, with a new spatial/ section that has a base, frontend, and backend, as well as it's own render layer, similar to volume rendering. In addition, a number of files were changed to remove parts that needed webgl context so that they could be more easily unit tested. A nice side benefit of this is clearer separation of concerns.
We were importing files which required webgl in a number of .spec files by faking the context or using await imports. Instead of working around this, in this commit we instead reorganise the files to split up a large file into the unit testable piece that doesn't need the browser or a webgl context, and the part that does. The part that does need it now gets tested via a browser_test.ts instead of a spec.ts file. Also fixes one other minor issue of testing a "legacy" path before this branch ever fully released. And a problem with the tools showing the delete/create status until the key was released, not when the operation was submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The responsibilities of the index file were getting a bit muddled and the size had
increased substantially. Instead aimed to keep the index file about the core
integration. It handles holding important state objects, forming attachments between
different objects, passing relevant state, holding key layers and core options.
Details relating to selection are moved to selection.ts and made only one owner of the
selected node.
ui concerns to /ui, mainly around selection details and sharing node icons and labels
Skeleton source connection links a layer and a skeleton source to share context for edit
commands, edit actions, and the find path tool.
We also reduce the changes dependent_view_widget.ts against master, as we still need a
way to stop rebuilding while setting node properties, but have a lighter weight solution
this time around
Finally we nest the skeleton browse options in the state under a new key
Also fixes the preview ID, so the selection details dont' show it, when selecting either
a node or segID