Skip to content

Make tox run the tests in generated packages #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjvrijn merged 3 commits into from
Oct 28, 2026
Merged

Make tox run the tests in generated packages #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3869035
fix(template): make tox run the tests in generated packages
simonvanlierde Oct 8, 2026
1445df4
docs: link the PR in the changelog entry
simonvanlierde Oct 26, 2026
5d9b9dc
Merge branch 'main' into fix/tox-run-tests
sjvrijn Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
* Removed Python 3.10 and 3.11 support
* Removed `setuptools-scm` from the build-system requirements: Files committed into the generated project's repository are no longer automatically included in releases [#713](https://github.com/NLeSC/python-template/pull/713)

### Fixed

* `tox` in a generated package now runs the tests: its table was misspelled `tool.box.testenv` [#716](https://github.com/NLeSC/python-template/pull/716)

## [0.6.1]

### Added
Expand Down
3 changes: 1 addition & 2 deletions template/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,9 @@ requires = ["tox>=4.22"]
env_list = [ "py312", "py313", "py314" ]
skip_missing_interpreters = true
{% if AddLocalTests -%}
[tool.box.testenv]
[tool.tox.env_run_base]
description = "Run test under {base_python}"
commands = [["pytest"]]
[tool.tox.env_run_base]
dependency_groups = [ "dev" ]
{%- endif %}

Expand Down
1 change: 1 addition & 0 deletions tests/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def test_tox(baked_with_development_dependencies, project_env_bin_dir):
result = run([f'{bin_dir}tox'], project_dir)
assert result.returncode == 0
assert 'congratulations :)' in result.stdout
assert '== 3 passed in' in result.stdout
# assert (project_dir / '.tox' / 'dist' / 'my_python_package-0.1.0.zip').exists()
assert (project_dir / '.tox' / '.pkg' / 'dist'/ 'my_python_package-0.1.0.tar.gz').exists()

Expand Down
Loading