Repository navigation
Fix FP8 current scaling FakeTensor output shape - #3659
Open
sanjana658 wants to merge 2 commits into
Open
sanjana658 wants to merge 2 commits into
sanjana658 wants to merge 2 commits into
Conversation
Contributor
|
added 2 commits
October 9, 2026 08:28
Signed-off-by: Sanjana Thanabalan <190764683+sanjana658@users.noreply.github.com>
Signed-off-by: Sanjana Thanabalan <190764683+sanjana658@users.noreply.github.com>
sanjana658
force-pushed
the
fix/3636-fp8-fake-scale-shape
branch
from
October 9, 2026 03:00
604ab7b to
019b153
Compare
Author
|
Hi maintainers, I've addressed the CI coverage feedback by adding the regression test to the L0 PyTorch test runner, and the DCO check is now passing. The PR is ready for review. Could someone please approve the pending workflows and review the changes when convenient? Thank you! |
ptrendx
reviewed
Oct 9, 2026
| @@ -0,0 +1,17 @@ | |||
| # Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
Member
There was a problem hiding this comment.
Please add this test to the existing test_onnx_export.py instead rather than creating a completely new file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Summary
tex::fp8_cs_quantize, matching the eager output metadata.torch.library.opcheckwithtest_faketensor.Validation
git diff --checkpassed.opchecktest has not been run locally because the local environment has no CUDA GPU and TransformerEngine's compiled package is not installed.Related issue: #3636