Repository navigation
Conversation
PyPI now has petsc and petsc4py 3.26.0 as source distributions, which pip prefers over the 3.26.0.dev0 wheels on the custom index and would compile. --only-binary keeps them on the wheels. --pre is no longer needed, as pip falls back to pre-releases when no final dolfinx exists, and petsc comes in as a dependency of petsc4py so it need not be listed.
The custom index now has petsc and petsc4py 3.26.0 wheels, the same version as the sdists on PyPI, and pip prefers a wheel over an sdist of the same version, so the flag no longer changes what gets installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PETSc 3.26.0 is out on PyPI, but only as source distributions of
petscandpetsc4py. The custom index at https://shimwell.github.io/wheels now has 3.26.0 wheels of both (shimwell/wheels#33). pip prefers a wheel over an sdist of the same version, so everything still installs from wheels, and the install command gets shorter:--preis removed. pip falls back to pre-releases when there is no finalfenics-dolfinx, and the dev version specifiers in its dependencies let basix, ffcx and ufl through too.petscis no longer listed, becausepetsc4pypulls it in. The earlier CI failure (libpetsc.so.3.025: cannot open shared object file) was the cp312petsc4pywheel on the index not declaringpetsc. That is fixed in the 3.26.0 wheels.A
pip install --dry-runof this command in a cleanpython:3.12container picks thepetscandpetsc4py3.26.0 wheels and downloads no sdists. The CI for this PR passed with the same wheels and the--only-binaryvariant.A future PETSc patch release published to PyPI as an sdist before matching wheels are on the index would make pip compile PETSc. The index needs new wheels when that happens, and the weekly CI run would catch it.
🤖 Generated with Claude Code