Repository navigation
Conversation
Maven 3.10.0 (now the default on the ubuntu-24.04 runner image) treats duplicate dependency declarations as a model error instead of a warning, which broke the 3.2.1 release build. Keep a single declaration with the effective compile scope.
vharseko
added
bug
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Release Mavenrun for 3.2.1 (run 37949221344) failed while Maven was still reading the project models:commons/http-framework/binding-test-utils/pom.xmldeclaresorg.assertj:assertj-coretwice. The duplicate is old: Maven 3.9.x only logged a[WARNING]about it, as the successful 3.2.0 release run shows (run 36534373230). The runner imageubuntu24/20261004.327updated the system Maven from 3.9.16 to 3.10.0. Maven 3.10.0 reports the same problem as an error, so the reactor fails before any build step runs. This affects every workflow that uses the systemmvnonubuntu-24.04, not only the release.Fix
Keep one
assertj-coredeclaration (the first one) and give itscope compile. Under Maven 3.9 the second declaration was the one in effect, and it had compile scope. With this change the resolved scope and the dependency order stay the same.Verification
help:effective-pomfor the module is byte-for-byte identical before and after the change.validateon the full reactor with Maven 3.10.0. With the original POM it reproduces the CI error exactly. With this change it ends inBUILD SUCCESS.