Skip to content

Allow Ares Academy add country-level filters - #2421

Open
dh381-1 wants to merge 9 commits into
Phobos-developers:developfrom
dh381-1:extra/Academy
Open

dh381-1 wants to merge 9 commits into
Phobos-developers:developfrom
dh381-1:extra/Academy

Conversation

@dh381-1

@dh381-1 dh381-1 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

  • Ares' Academy feature could previously only add Academy.Types and Academy.Ignore to buildings. Now, Academy.Country.Types.* and Academy.Country.Ignore.* can be used to add country-level filters to buildings.

In rulesmd.ini:

[SOMEBUILDING]               ; BuildingType
Academy.Country.Types.N=     ; List of TechnoType, empty for all types
Academy.Country.Ignore.N=    ; List of TechnoType
; Where N is 0,1,2...15.
  • Additionally, Academy.AllowCountryFilter must be set for a country to enable this feature. Only countries with this feature enabled will use the academy's Academy.Country.Types.* and Academy.Country.Ignore.* instead of Academy.Types and Academy.Ignore.

In rulesmd.ini:

[SOMECOUNTRY]                       ; Country
Academy.AllowCountryFilter=false    ; boolean

@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/786/1

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Comment thread docs/New-or-Enhanced-Logics.md Outdated
Comment on lines +853 to +884
Academy.Country.Types.0= ; List of TechnoType, empty for all types
Academy.Country.Ignore.0= ; List of TechnoType
Academy.Country.Types.1= ; List of TechnoType, empty for all types
Academy.Country.Ignore.1= ; List of TechnoType
Academy.Country.Types.2= ; List of TechnoType, empty for all types
Academy.Country.Ignore.2= ; List of TechnoType
Academy.Country.Types.3= ; List of TechnoType, empty for all types
Academy.Country.Ignore.3= ; List of TechnoType
Academy.Country.Types.4= ; List of TechnoType, empty for all types
Academy.Country.Ignore.4= ; List of TechnoType
Academy.Country.Types.5= ; List of TechnoType, empty for all types
Academy.Country.Ignore.5= ; List of TechnoType
Academy.Country.Types.6= ; List of TechnoType, empty for all types
Academy.Country.Ignore.6= ; List of TechnoType
Academy.Country.Types.7= ; List of TechnoType, empty for all types
Academy.Country.Ignore.7= ; List of TechnoType
Academy.Country.Types.8= ; List of TechnoType, empty for all types
Academy.Country.Ignore.8= ; List of TechnoType
Academy.Country.Types.9= ; List of TechnoType, empty for all types
Academy.Country.Ignore.9= ; List of TechnoType
Academy.Country.Types.10= ; List of TechnoType, empty for all types
Academy.Country.Ignore.10= ; List of TechnoType
Academy.Country.Types.11= ; List of TechnoType, empty for all types
Academy.Country.Ignore.11= ; List of TechnoType
Academy.Country.Types.12= ; List of TechnoType, empty for all types
Academy.Country.Ignore.12= ; List of TechnoType
Academy.Country.Types.13= ; List of TechnoType, empty for all types
Academy.Country.Ignore.13= ; List of TechnoType
Academy.Country.Types.14= ; List of TechnoType, empty for all types
Academy.Country.Ignore.14= ; List of TechnoType
Academy.Country.Types.15= ; List of TechnoType, empty for all types
Academy.Country.Ignore.15= ; List of TechnoType

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the implementation of other "XXN" flags, such as type conversion.

@TaranDahl

Copy link
Copy Markdown
Contributor


In `rulesmd.ini`:
```ini
[SOMEBUILDING] ; BuildingType

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the flag in country sections merely serves as a global enabling statement for building flags, then its documentation paragraph only needs to be placed in the Buildings section, just as a techno flag is not regarded as a global feature simply because a toggle in [General] is also added at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants