syamv/heamv: Fix SYMB_ZERO strided indexing - #1394
Open
jschueller wants to merge 1 commit into
Open
jschueller wants to merge 1 commit into
jschueller wants to merge 1 commit into
Conversation
Open
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1394 +/- ##
=======================================
Coverage 69.39% 69.39%
=======================================
Files 6122 6122
Lines 487623 487623
Branches 23268 23268
=======================================
Hits 338408 338408
Misses 148781 148781
Partials 434 434
Continue to review full report in Codecov by Harness.
|
In INCX != 1 branches SYMB_ZERO test used X(J) instead of X(JX), while accumulation correctly used X(JX). Fix to X(JX) for dla/sla/cla/zla_syamv.f and cla/zla_heamv.f (4 occurrences each, both UPLO variants). Restores correct symbolic-zero perturbation (SAFE1) for error-bound estimation with strided X.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In INCX != 1 branches SYMB_ZERO test used X(J) instead of X(JX), while accumulation correctly used X(JX). Fix to X(JX) for dla/sla/cla/zla_syamv.f and cla/zla_heamv.f (4 occurrences each, both UPLO variants). Restores correct symbolic-zero perturbation (SAFE1) for error-bound estimation with strided X.
part of #1312