Repository navigation
ci: run CI on master, and build packages before type-check - #14
Merged
Merged
Conversation
Both CI triggers pointed at a `main` branch that doesn't exist — the repo's default branch is `master` — so the CI workflow has never run once: every PR to date merged with zero checks. Fixing the branch name alone would turn CI red immediately, because `pnpm type-check` fails on a fresh checkout: workspace packages resolve each other's types from built dist output (e.g. tinypivot-server imports @smallwebco/tinypivot-core). Add a build step before type-check in the lint job. Verified locally in CI order: pnpm lint, pnpm build, pnpm type-check, pnpm test:unit — all green (241/241 tests). deploy.yml also watches `main` but is left untouched: it targets GitHub Pages, which is not enabled for this repo (the site deploys via Vercel), so pointing it at master would only add a failing workflow.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while merging #13: both CI triggers in
ci.ymlpoint at amainbranch that doesn't exist — the default branch ismaster— so the CI workflow has never run once. Every PR to date (including #13) merged with zero checks, which is why they all show as instantly mergeable.Changes
ci.ymltriggers:branches: [main]→branches: [master]for bothpushandpull_requestpnpm buildstep beforeType checkin the lint job — flipping the branch alone would have turned CI red immediately, becausepnpm type-checkfails on a fresh checkout (workspace packages resolve each other's types from builtdistoutput, e.g.tinypivot-serverimports@smallwebco/tinypivot-core)deploy.ymlalso watchesmainbut is deliberately untouched: it targets GitHub Pages, which isn't enabled for this repo (the site deploys via Vercel), so pointing it atmasterwould only add a failing workflow. It's likely deletable.Verification
Ran the CI jobs' exact steps locally in order:
pnpm lint,pnpm build,pnpm type-check,pnpm test:unit— all green (241/241 tests). This PR itself should be the first to show a real CI run.Generated by Claude Code