Repository navigation
fix(examples): Inkplate10 HTTP request example fetches a page that exists - #316
Merged
Merged
Conversation
…ists The example requested http://example.com/index.html, which example.com now answers with a 404, so the board printed an error page instead of the demo page. The scanned network list also ran together on the screen, because nothing separated one entry from the next after its signal strength. Request http://example.com/ instead, and end every network entry with a new line so each one gets its own line. Use text size 4 for everything on the screen, including the page, which the example used to print at size 1. At size 1 the text was too small to read on the 9.7 inch screen, and the whole page still fits at size 4. Run on an Inkplate 10 with the same code: the networks are listed one per line, the dots appear while connecting, and the page text is large and readable.
Member
|
LGTM, very nicely done and explained |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example requested http://example.com/index.html, which example.com now
answers with a 404, so the board printed an error page instead of the demo
page. The scanned network list also ran together on the screen, because
nothing separated one entry from the next after its signal strength.
Request http://example.com/ instead, and end every network entry with a new
line so each one gets its own line. Use text size 4 for everything on the
screen, including the page, which the example used to print at size 1. At size 1
the text was too small to read on the 9.7 inch screen, and the whole page still
fits at size 4.
Run on an Inkplate 10 with the same code: the networks are listed one per line,
the dots appear while connecting, and the page text is large and readable.