Skip to content

implement changes to shared access - #884

Merged
SharonStrats merged 4 commits into
stagingfrom
feat/shared-with
Oct 8, 2026
Merged

SharonStrats merged 4 commits into
stagingfrom
feat/shared-with

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Implement the shared with area, so that a user can change existing access. Plus some cleanup.

Some notes:

  • you'll see we don't have the search icon in the search box. When I first implemented it I added it to the solid-ui-input, because that is what I was using but then I realized I needed the combobox. In order to add it in again I'd need to modify the combobox. I'm going to leave it and we can discuss it at the end.
  • Also I'm thinking that the search box should be wider than the design. I'll leave it for now, but I will bring it up later or maybe just change it. I'll see at the end.
  • Also wondering about the font, seems a bit too big but this was from design. 14px.

Here is how the search looks
Screenshot 2026-10-07 at 3 13 40 PM

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Saving a multi-subject authorization updates only its first subject.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Implements editing and saving existing shared-access grants in the access-control modal.

Changes:

  • Enables saving modified grant roles.
  • Adds unified planner support for origin grants.
  • Updates grant rendering and tests.
File Description
AccessControlModal.ts Tracks and persists edited access roles.
access-control-modal.test.ts Tests origin and existing-grant updates.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/access-control-modal/AccessControlModal.ts Outdated
@SharonStrats
SharonStrats force-pushed the feat/shared-with branch 5 times, most recently from b274156 to de75d1a Compare October 7, 2026 04:44

@timea-solid timea-solid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Base automatically changed from feat/access-input to staging October 8, 2026 10:28
@SharonStrats
SharonStrats merged commit 70ec15f into staging Oct 8, 2026
9 checks passed
@SharonStrats
SharonStrats deleted the feat/shared-with branch October 8, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Sharing pane - change role directly in People with Access view

3 participants