Repository navigation
implement changes to shared access - #884
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Saving a multi-subject authorization updates only its first subject.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Implements editing and saving existing shared-access grants in the access-control modal.
Changes:
- Enables saving modified grant roles.
- Adds unified planner support for origin grants.
- Updates grant rendering and tests.
| File | Description |
|---|---|
AccessControlModal.ts |
Tracks and persists edited access roles. |
access-control-modal.test.ts |
Tests origin and existing-grant updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
feat/shared-with
branch
5 times, most recently
from
October 7, 2026 04:44
b274156 to
de75d1a
Compare
SharonStrats
force-pushed
the
feat/access-input
branch
from
October 8, 2026 09:55
e80ad9c to
9d06f5d
Compare
SharonStrats
force-pushed
the
feat/shared-with
branch
from
October 8, 2026 10:46
de75d1a to
e011777
Compare
SharonStrats
force-pushed
the
feat/shared-with
branch
from
October 8, 2026 10:52
908e622 to
d2828e7
Compare
…istry@5.0.2-0) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implement the shared with area, so that a user can change existing access. Plus some cleanup.
Some notes:
Here is how the search looks
