Repository navigation
Feat/access general - #888
Merged
Merged
Conversation
Prompt: tests were created by ai Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
SharonStrats
requested review from
timea-solid
and
a balanced review from Copilot
October 9, 2026 09:56
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Mixed authorizations can be hidden, failed grants silently dropped, and directory styling cannot cross the shadow boundary.
3 open findings
What changed in this PR
Adds authenticated and public general-access controls to the sharing modal.
Changes:
- Adds separate authenticated/public role selectors and persistence.
- Excludes general grants from shared-user listings.
- Reopens comboboxes on click and expands tests.
| File | Description |
|---|---|
AccessControlModal.ts |
Implements general-access UI and saving. |
AccessControlModal.styles.css |
Styles new controls and labels. |
helpers.ts |
Adds URI and deduplication helpers. |
Combobox.ts |
Reopens options when clicked. |
access-control-modal.test.ts |
Tests general-access behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+966
to
971
| <span class="access-grants-directory-entry"> | ||
| <!-- This renders inside the combobox shadow DOM, so the modal stylesheet cannot reach these icons. | ||
| If combobox supports a dedicated option icon hook, we can move this sizing there instead. --> | ||
| ${this.renderDirectoryEntryIcon(entry)} | ||
| <span>${entry.label}</span> | ||
| </span> |
Contributor
Author
There was a problem hiding this comment.
the comment was for the styles on the icons. I'm going to leave this as is for now as perhaps we will modify the combobox.
Prompt: Should I address the feedback about errors now, as I am going to implement error handling later. If so please add a temporary fix. Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
SharonStrats
force-pushed
the
feat/access-general
branch
from
October 9, 2026 10:24
9bc8294 to
8d600f5
Compare
…istry@5.0.2-0) (latest: rdflib@2.4.1)
timea-solid
approved these changes
Oct 9, 2026
SharonStrats
force-pushed
the
feat/access-general
branch
from
October 9, 2026 18:40
c7258e6 to
c013c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the general access area. The public can only change to 'Viewer', while authenticated agent has all options for a role available.
I also found a funny problem with the combobox which also exists in profile-pane oddly enough. We were not able to reclick and pick another value if you change your mind before you save. So I just added an @click.
Here is how it looks
Needs this PR SolidOS/solid-logic#341 first