test(lit-query/useMutationState): add test for returning the current mutation states when connected after a mutation started by sukvvon · Pull Request #11803 · TanStack/query

sukvvon · 2026-10-02T00:51:45Z

🎯 Changes

Adds "should return the current mutation states when connected after a mutation started" to useMutationState tests.

A mutation is started before the host using useMutationState with static filters ({ status: 'pending' }) is connected. It asserts that the rendered output shows the pending mutation right after connecting, and then none once the mutation settles.

Existing tests connected the host before mutating, or used a select function that recomputes the state on host updates, so none checked that the state is computed when the host connects.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage confirming that a host connected after a mutation begins can observe its pending state, and that the pending count returns to zero when the mutation completes.

…mutation states when connected after a mutation started

nx-cloud · 2026-10-02T00:52:09Z

View your CI Pipeline Execution ↗ for commit 2a3e617

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 48s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-02 00:55:38 UTC

github-actions · 2026-10-02T00:52:29Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-02T00:53:02Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 02397028-7ec0-43e1-96ff-9a10150e7f08

📥 Commits

Reviewing files that changed from the base of the PR and between 113ce9d and 2a3e617.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/useMutationState.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The change adds a test that checks whether useMutationState observes a pending mutation created before the observing host connects. The test also checks that the filtered count returns to zero after the mutation completes.

Changes

Mutation state observation

Layer / File(s)	Summary
Observe a pending mutation after host connection `packages/lit-query/src/__tests__/useMutationState.test.ts`	The test starts a mutation before connecting a host that observes pending mutations. It checks for one pending mutation before completion and zero afterward.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2a3e6

This test-only change adds coverage for observing an already-pending mutation after connection. No actionable merge-blocking risk is identified; merge after normal checks pass.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added `useMutationState` test and the connection timing it covers. It is specific and related to the main change, although it is somewhat long.
Description check	✅ Passed	The description explains the test change and motivation. It includes all required sections, and the checklist and release impact entries are completed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-02T00:53:50Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11803

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11803

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11803

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11803

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11803

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11803

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11803

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11803

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11803

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11803

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11803

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11803

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11803

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11803

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11803

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11803

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11803

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11803

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11803

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11803

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11803

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11803

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11803

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11803

commit: 2a3e617

github-actions · 2026-10-02T00:54:00Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/useMutationState): add test for returning the current …

2a3e617

…mutation states when connected after a mutation started

sukvvon self-assigned this Oct 2, 2026

sukvvon merged commit d49c1f5 into main Oct 2, 2026
9 checks passed

sukvvon deleted the test/lit-query-use-mutation-state-connected-after-mutation branch October 2, 2026 01:24

Navigation Menu

Uh oh!

test(lit-query/useMutationState): add test for returning the current mutation states when connected after a mutation started - #11803

test(lit-query/useMutationState): add test for returning the current mutation states when connected after a mutation started#11803
sukvvon merged 1 commit into
mainfrom
test/lit-query-use-mutation-state-connected-after-mutation

sukvvon commented Oct 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

coderabbitai Bot commented Oct 2, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Oct 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 2, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 2, 2026

Uh oh!

github-actions Bot commented Oct 2, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 2, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 2, 2026 •

edited

Loading

coderabbitai Bot commented Oct 2, 2026 •

edited

Loading