Repository navigation
Replace @acemir/cssom with cssomnom/parse - #356
Conversation
| @@ -1,4 +1,4 @@ | |||
| import uhyphen from 'uhyphen'; | |||
| const uhyphen = camel => camel.replace(/(([A-Z0-9])([A-Z0-9][a-z]))|(([a-z0-9]+)([A-Z]))/g, '$2$5-$3$6').toLowerCase(); | |||
There was a problem hiding this comment.
I know uhyphen is one line dependency but that's still used in more than a place, was this change necessary? 🤔
|
hi @paulirish - first of all, thank you! secondly, I believe inlining uhyphen did cause the regression around coverage ... I know that module is left-pad-ish but it's still my module, code-covered and everything, and I've been using it here and there to stop thinking about it ... shall we put back it as import? Last, b ut not least, what should I bump? major, minor or patch? if things are similar but fixed I think patch is fine but as the library is different maybe minor would be appropriate? I had different ideas for major but I also wouldn't mind bumping major if needed, thanks for helping me out brainstorming this! |
|
Yeah I preferred dropping the uphyphen dependency (not realizing it was yours) especially cuz we could delete code and improve on conformance. BUTTT I also don't care that much... I dropped that bit.. which also means no userfacing change too (the Now with |
|
it's in, thank you! |
Fixes #352.
Swaps
@acemir/cssomforcssomnom/parseinesm/html/style-element.js(leavingesm/interface/css-style-declaration.jsanduhyphenuntouched soel.style.toString()stays identical).What this changes:
exports, so Vite/Rolldown/esbuild browser and worker builds resolve cleanly.el.style(esm/interface/css-style-declaration.js) withcssomnom'sCSSStyleDeclaration+onChangehook too (which fixesel.style.property = ''ande.style.setProperty('property', '')should delete the property #327), that commit is preserved in history at2a6a684.