Skip to content

fix: treat undefined force as omitted in classList.toggle #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnhldiver-beep wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: treat undefined force as omitted in classList.toggle #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cjs/dom/token-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class DOMTokenList extends Set {
this.delete(token);
update(this);
}
else if (force || arguments.length === 1) {
else if (force || force === undefined) {
super.add(token);
update(this);
return true;
Expand Down
2 changes: 1 addition & 1 deletion esm/dom/token-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class DOMTokenList extends Set {
this.delete(token);
update(this);
}
else if (force || arguments.length === 1) {
else if (force || force === undefined) {
super.add(token);
update(this);
return true;
Expand Down
5 changes: 5 additions & 0 deletions test/html/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ node.classList.toggle('test', true);
assert(node.classList.contains('test'), true, 'test class still in');
node.classList.toggle('test', false);
node.classList.toggle('test', true);
// issue #277: explicit undefined force must behave like an omitted argument
assert(node.classList.toggle('test', undefined), false, 'toggle(test, undefined) when present removes and returns false');
assert(node.classList.contains('test'), false, 'no test class after toggle(test, undefined)');
assert(node.classList.toggle('test', undefined), true, 'toggle(test, undefined) when absent adds and returns true');
assert(node.classList.contains('test'), true, 'test class added by toggle(test, undefined)');
node.classList.remove('test');
assert(node.classList.contains('test'), false, 'no test class one more time');
assert(node.classList.replace('b', 'c'), true, 'replace happened');
Expand Down