Tests: Improve isolation for randomized media tests by sirreal · Pull Request #13190 · WordPress/wordpress-develop

sirreal · 2026-08-20T04:25:46Z

Summary

Resets loading-optimization state before each test and moves the remote image-cropping test into the external-HTTP group, preserving remote-fetch coverage.
Accepts generated caption-ID suffixes and derives expected attachment names from the files actually uploaded.
Restores the incoming HTTPS server value after attachment tests so a class-level fixture cannot capture leaked request state.
Keeps the changes confined to PHPUnit tests and fixtures.

Verification

Minimized seed 1789074025 to the HTTPS-mutating attachment test followed by the attachment-link class fixture, then replayed the full failing seed after the fix.
100 consecutive fresh randomized media-group runs passed on the combined campaign branch after resetting the counter; each completed 842 tests and 2,220 assertions with 52 expected skips.
Exact seeds 1789084001 through 1789084100 all exited cleanly without exclusions or replays; maximum PHPUnit time was 33.552 seconds.
All three relevant changed file trees match this isolated PR branch, and the HTTPS restoration patch ID matches the gated commit.
PHP syntax checks and git diff --check passed.

Trac: https://core.trac.wordpress.org/ticket/65893

github-actions · 2026-08-20T16:55:26Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

lancewillett · 2026-09-03T19:36:45Z

Refreshed with current trunk in a non-rewriting merge: 51c5e19.

Validation passed: git diff --check; vendor/bin/phpcs --standard=phpcs.xml.dist for the three changed PHP test files; and a focused randomized PHPUnit contamination replay (seed 13190): 7 tests, 32 assertions.

Limitation: this was a targeted replay; the new CI run provides the full matrix.

Restores the remote URL in `Tests_Image_Functions::test_wp_crop_image_with_url()` and tags the test `external-http`, so it no longer runs by default and needs no network, but still covers cropping a remote image when that group runs. See #65893. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

lancewillett · 2026-09-30T17:21:34Z

Refreshed this against trunk and changed one thing.

The media.php resets fix Tests_Media::test_wp_get_attachment_image_fetchpriority_high_when_not_lazy_loaded at seed 2 of --group media, and the caption regex fixes test_img_caption_shortcode_with_old_format_id_and_align at seed 2 of the top-level files.
The HTTPS restore fixes a leak into the next class: the HTTPS attachment test followed by Tests_Post_WpGetAttachmentLink fails on trunk (the link comes out https://) and passes with this branch.
I put back the remote URL in test_wp_crop_image_with_url and tagged it external-http instead of switching to file://. The file:// version no longer tests a remote fetch; the group keeps it out of default runs, and CI still runs it in the external-http step.

--group media and post/ pass in default order and seeds 1–3.

github-actions · 2026-09-30T17:21:47Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, lancewillett, adrianmoldovanwp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot

Copilot review overview

🟡 Changes recommended

The crop test remains network-dependent despite the summary claiming replacement with a local fixture.

Review effort: Balanced
Findings: 1

Open (1)

Use a local fixture and include the test in the PHPUnit suite · New

What changed in this PR

Improves isolation and stability of randomized media PHPUnit tests.

Changes:

Resets media optimization state between tests.
Restores HTTPS state and derives uploaded filenames dynamically.
Reclassifies a live crop test as external HTTP.

File	Description
`tests/phpunit/tests/post/attachments.php`	Restores HTTPS state and supports randomized upload names.
`tests/phpunit/tests/media.php`	Resets media state and accepts generated caption IDs.
`tests/phpunit/tests/image/functions.php`	Marks the live crop test as external HTTP.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Reset loading-optimization state before each media test, accept valid generated caption-ID suffixes, and derive expected attachment filenames from the uploaded files. Restore the incoming HTTPS server value after attachment tests. Group the remote image-cropping test under external-http, preserving its remote-fetch coverage while keeping it out of the default test run. Developed in: #13190 Props jonsurrell, adrianmoldovanwp. See #65893. git-svn-id: https://develop.svn.wordpress.org/trunk@64042 602fd350-edb4-49c9-b593-d223f7449a82

lancewillett · 2026-10-01T21:49:35Z

PR #13190 landed in https://core.trac.wordpress.org/changeset/64042

Reset loading-optimization state before each media test, accept valid generated caption-ID suffixes, and derive expected attachment filenames from the uploaded files. Restore the incoming HTTPS server value after attachment tests. Group the remote image-cropping test under external-http, preserving its remote-fetch coverage while keeping it out of the default test run. Developed in: WordPress/wordpress-develop#13190 Props jonsurrell, adrianmoldovanwp. See #65893. Built from https://develop.svn.wordpress.org/trunk@64042 git-svn-id: http://core.svn.wordpress.org/trunk@63201 1a063a9b-81f0-0310-95a4-ce76da25c4cd

sirreal added 2 commits August 20, 2026 08:24

Tests: Improve isolation for randomized media tests

dbeace5

Tests: Restore HTTPS state after attachment tests

4690b06

sirreal mentioned this pull request Aug 20, 2026

Build/Test Tools: Reset shared state in the base test case instead of per test file sirreal/wordpress-develop#95

Open

Merge branch trunk into agent/test-order-media-isolation

51c5e19

lancewillett and others added 2 commits September 30, 2026 09:49

Merge remote-tracking branch 'origin/trunk' into jon-13190

06a9207

lancewillett marked this pull request as ready for review September 30, 2026 17:21

lancewillett requested review from adimoldovan and mindctrl September 30, 2026 17:22

lancewillett mentioned this pull request Oct 1, 2026

Tests: Read the video shortcode instance number in test_video_shortcode_body() #13904

Closed

adimoldovan approved these changes Oct 1, 2026

View reviewed changes

lancewillett requested a balanced review from Copilot October 1, 2026 21:24

Copilot started reviewing on behalf of lancewillett October 1, 2026 21:24 View session

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Comment thread tests/phpunit/tests/image/functions.php

lancewillett closed this Oct 1, 2026

Navigation Menu

Tests: Improve isolation for randomized media tests - #13190

Tests: Improve isolation for randomized media tests#13190
sirreal wants to merge 5 commits into
WordPress:trunkfrom
sirreal:agent/test-order-media-isolation

sirreal commented Aug 20, 2026 •

edited by lancewillett

Loading

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

lancewillett commented Sep 3, 2026

Uh oh!

lancewillett commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

lancewillett commented Oct 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sirreal commented Aug 20, 2026 • edited by lancewillett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Uh oh!

github-actions Bot commented Aug 20, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

lancewillett commented Sep 3, 2026

Uh oh!

lancewillett commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

lancewillett commented Oct 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sirreal commented Aug 20, 2026 •

edited by lancewillett

Loading

github-actions Bot commented Sep 30, 2026 •

edited

Loading