Plugins: Fix wp_edit_theme_plugin_file() to detect network-active plugins - #13620
Closed
bishalsthadev wants to merge 5 commits into
Closed
bishalsthadev wants to merge 5 commits into
bishalsthadev wants to merge 5 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
requested changes
Sep 21, 2026
plugins. $is_active only checked the site-level active_plugins option, so the fatal-error loopback check was silently skipped for network-active plugins. Use is_plugin_active() instead, which already accounts for network activation.
bishalsthadev
force-pushed
the
fix/66129-network-active-plugin-check
branch
from
September 28, 2026 14:42
80f1bf0 to
ce9e77c
Compare
westonruter
approved these changes
Sep 28, 2026
wporg-sync
pushed a commit
that referenced
this pull request
Sep 28, 2026
The `wp_edit_theme_plugin_file()` function determined whether a plugin was active by only checking the site-level `active_plugins` option, so network-active plugins were treated as inactive and the loopback request that checks for fatal errors was skipped when editing their PHP files. Now `is_plugin_active()` is used instead, which also accounts for network activation. Developed in #13620. Follow-up to r41721, r63957. Props rainynewt, westonruter, denisflorin117. See #66133. Fixes #66129. git-svn-id: https://develop.svn.wordpress.org/trunk@63982 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Sep 28, 2026
The `wp_edit_theme_plugin_file()` function determined whether a plugin was active by only checking the site-level `active_plugins` option, so network-active plugins were treated as inactive and the loopback request that checks for fatal errors was skipped when editing their PHP files. Now `is_plugin_active()` is used instead, which also accounts for network activation. Developed in WordPress/wordpress-develop#13620. Follow-up to r41721, r63957. Props rainynewt, westonruter, denisflorin117. See #66133. Fixes #66129. Built from https://develop.svn.wordpress.org/trunk@63982 git-svn-id: http://core.svn.wordpress.org/trunk@63145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://core.trac.wordpress.org/ticket/66129
wp_edit_theme_plugin_file() checked plugin activity with a raw in_array()
against the active_plugins option, which never accounts for network-wide
activation. is_plugin_active() already handles both cases and is used
elsewhere in this file, so this swaps in that helper and adds a
multisite unit test for the loopback-check behavior.