Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 24, 2026
…4427) Trac ticket: Core-66176 See WordPress/wordpress-develop#13720 There has been a known memory explosion for posts with deep stacks of unclosed blocks. These posts experience exponential memory use and can require gigabytes of memory to parse completely. This was due to a mismatch in the spec and default parsers which led to catastrophic string duplciation on account of how the default parser closed out these blocks. In this patch, the behavior is updated to implicitly close all open blocks when the end of the document is reached. This remains divergent from the spec parser, which treats a failure to find the closing delimiters as one giant freeform block, but the behavior should be better in general for truncated posts, given that it leaves intact as many elements of the block structure as are viable. Github-PR: 74427 Github-PR-URL: #74427
This patch unifies parsing between `WP_Block_Parser` and `WP_Block_Processor`, which brings the additional benefit of the optimizations in `WP_Block_Processor`.
This patch unifies parsing between `WP_Block_Parser` and `WP_Block_Processor`, which brings the additional benefit of the optimizations in `WP_Block_Processor`.
See WordPress/gutenberg#74427. When reaching the end of a document during block parsing, and blocks remain open, existing open blocks should implicitly close. Previously, there was a mistake in the closing code which duplicated content in the implicitly-closed blocks. In this patch, the semantic actions of closing blocks is extracted for easier identification of the logic, and the defect is resolved.
dmsnell
force-pushed
the
blocks/fix-parser-when-missing-closers
branch
from
September 29, 2026 18:22
26b34f0 to
236659f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-66176
See WordPress/gutenberg#74427.
Dependent on #13695.
When reaching the end of a document during block parsing, and blocks
remain open, existing open blocks should implicitly close. Previously,
there was a mistake in the closing code which duplicated content in the
implicitly-closed blocks.
In this patch, the semantic actions of closing blocks is extracted for
easier identification of the logic, and the defect is resolved.