Skip to content

Tests: Fix two widget tests that depend on test order #13863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lancewillett wants to merge 2 commits into from
Closed

Tests: Fix two widget tests that depend on test order #13863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1478021
Tests: Set the current sidebars widgets in the Customizer `retrieve_w…
lancewillett Sep 30, 2026
7492cf4
Tests: Reset the Customizer manager between `WP_Widget_Media` tests.
lancewillett Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/phpunit/tests/widgets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,6 +1189,8 @@ public function test_retrieve_widgets_for_customizer() {
);
set_theme_mod( 'sidebars_widgets', $old_sidebars_widgets );

$sidebars_widgets = $old_sidebars_widgets;

$result = retrieve_widgets( 'customize' );

$_wp_sidebars_widgets = array();
Expand Down
12 changes: 7 additions & 5 deletions tests/phpunit/tests/widgets/wpWidgetMedia.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,16 @@ class Tests_Widgets_wpWidgetMedia extends WP_UnitTestCase {
/**
* Clean up global scope.
*
* @global WP_Scripts $wp_scripts
* @global WP_Styles $wp_styles
* @global WP_Scripts $wp_scripts
* @global WP_Styles $wp_styles
* @global WP_Customize_Manager $wp_customize
*/
public function clean_up_global_scope() {
global $wp_scripts, $wp_styles;
global $wp_scripts, $wp_styles, $wp_customize;
parent::clean_up_global_scope();
$wp_scripts = null;
$wp_styles = null;
$wp_scripts = null;
$wp_styles = null;
$wp_customize = null;
}

/**
Expand Down
Loading