Skip to content

checks: add actionable assertion messages to advanced OOP checks - #164

Open
mercael91 wants to merge 10 commits into
abhiksark:devfrom
mercael91:fix/issue-107
Open

mercael91 wants to merge 10 commits into
abhiksark:devfrom
mercael91:fix/issue-107

Conversation

@mercael91

@mercael91 mercael91 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #107.

Adds an actionable message to each of the 8 bare asserts the issue lists, across checks/oop_advanced/oop_advanced1.py … oop_advanced6.py. What each check tests is unchanged.

  • expected value is named in every message;
  • the actual value is reported where it is cheap, bound to a local first (got, area, count, text) so the learner's function is never re-called inside the message;
  • every line stays within 80 characters.

Verified locally: 8/8 asserts now carry a message (AST), ast.parse clean on all six files, no line over 80 chars.

Signed-off-by: mercael <mercael91@gmail.com>
Signed-off-by: mercael <mercael91@gmail.com>
Signed-off-by: mercael <mercael91@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8a4a8e2a-3f85-40c2-9c23-2b8b96735f71

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mercael91 mercael91 changed the title Fix #107 checks: add actionable assertion messages to advanced OOP checks Oct 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant