Fix 32-bit x86 build of hash.cc - #2177
Open
jaipaulcheernam wants to merge 1 commit into
Open
jaipaulcheernam wants to merge 1 commit into
jaipaulcheernam wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The x86 AES SIMD path in absl/hash/internal/hash.cc uses the 64-bit-only _mm_cvtsi128_si64 and _mm_extract_epi64 intrinsics but is gated only on __SSE4_2__ && __AES__, so 32-bit x86 builds fail to compile. Require __x86_64__/_M_X64 for that path, matching the existing guard in absl/crc/internal/crc32_x86_arm_combined_simd.h. Fixes: abseil#2176
jaipaulcheernam
force-pushed
the
fix-32bit-x86-hash-simd
branch
from
September 24, 2026 15:50
3ac1b3c to
be307ee
Compare
mkruskal-google
approved these changes
Sep 25, 2026
mkruskal-google
self-requested a review
September 25, 2026 06:12
mkruskal-google
removed their request for review
September 25, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The x86 AES SIMD path in absl/hash/internal/hash.cc uses the 64-bit-only _mm_cvtsi128_si64 and _mm_extract_epi64 intrinsics but is gated only on SSE4_2 && AES, so 32-bit x86 builds fail to compile.
Require x86_64/_M_X64 for that path, matching the existing guard in absl/crc/internal/crc32_x86_arm_combined_simd.h.
Fixes: #2176
Thank you for your contribution to Abseil!
Before submitting this PR, please be sure to read our contributing
guidelines.
If you are a Googler, please also note that it is required that you send us a
Piper CL instead of using the GitHub pull-request process. The code propagation
process will deliver the change to GitHub.