Repository navigation
[dashboard] Set recruitment target directly in testLocal - #11262
Open
HenriRabalais wants to merge 2 commits into
Open
HenriRabalais wants to merge 2 commits into
HenriRabalais wants to merge 2 commits into
Conversation
HenriRabalais
added
Module: dashboard
HenriRabalais
added
the
State: Blocking
github-actions
Bot
added
the
Module: candidate_parameters
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DashboardTest::testLocalsets the recruitment target by clicking through the configuration page.DashboardTest::tearDownsetsprojectDescriptionto NULL after every test, and with no English translation to fall back on, the configuration page throws a TypeError and never renders its tabs. SotestLocalonly passes when it runs before the other dashboard tests, which depends on how the integration tests get split across CI shards. On #11259 one extra test method moves it into the other shard and it fails.Changes
recruitmentTargetwithsetupConfigSettingin_testPlan3and restore it afterwards, the same way_testPlan2does. This matchesmainsince [configuration] Reactify study entity forms #10993.Testing Instructions
docker (integration)passes on every shard.Related Issues
Unblocks #11259.