Skip to content

[biobank] Link Visit Label to the instrument list on the Pool tab - #11278

Open
HenriRabalais wants to merge 1 commit into
aces:mainfrom
HenriRabalais:2026-11-02_biobank-pool-visit-label
Open

HenriRabalais wants to merge 1 commit into
aces:mainfrom
HenriRabalais:2026-11-02_biobank-pool-visit-label

Conversation

@HenriRabalais

Copy link
Copy Markdown
Collaborator

Description

On the Pool tab, formatPoolColumns looks for the visit's session among the values of the candidate entry in options.candidates. None of them has a label, so the session ID is always undefined and the Visit Label renders as plain text.

The candidate entry carries its sessionIds, and the Specimen tab already finds the session through them.

Changes

  • Found the session for the Visit Label link through the candidate's sessionIds, as the Specimen tab does.

Testing Instructions

  1. Open the Biobank module and go to the Pool tab.
  2. Click a Visit Label. It opens the visit's instrument list.

Related Issues

Mirrors aces/biobank#289

@github-actions github-actions Bot added the Language: Javascript PR or issue that update Javascript code label Nov 2, 2026
@HenriRabalais HenriRabalais added the Module: biobank PR or issue related to biobank module label Nov 2, 2026
@HenriRabalais HenriRabalais self-assigned this Nov 2, 2026
@HenriRabalais HenriRabalais added the Category: Bug PR or issue that aims to report or fix a bug label Nov 2, 2026

@MaximeBICMTL MaximeBICMTL left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test the change as the Biobank does not have any Raisinbread data but the old code looks incorrect (candidates iterated as sess) and the new code makes more sense.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Bug PR or issue that aims to report or fix a bug Language: Javascript PR or issue that update Javascript code Module: biobank PR or issue related to biobank module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants