Skip to content

fix: allow empty Redis connection user with ACL tip - #906

Closed
LordofAvernus wants to merge 2 commits into
mainfrom
dms-ui/fix-3186
Closed

LordofAvernus wants to merge 2 commits into
mainfrom
dms-ui/fix-3186

Conversation

@LordofAvernus

Copy link
Copy Markdown
Collaborator

关联的 issue

https://github.com/actiontech/sqle-ee/issues/3186

描述你的变更

  • Redis 数据源「连接用户」改为非必填,并展示 ACL / Redis 5.x 留空提示
  • 补充 FormItem 单测覆盖 Redis / 非 Redis 必填语义

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

Made with Cursor

LordofAvernus and others added 2 commits November 2, 2026 10:52
Mark Redis user optional and show 5.x/ACL guidance so requirepass
instances are not blocked by the previous non-cluster required rule.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 80.58% 30424/37758
🟡 Branches 62.81% 11437/18208
🟢 Functions 83.97% 10200/12147
🟢 Lines 84.39% 29073/34452

Test suite run success

3786 tests passing in 827 suites.

Report generated by 🧪jest coverage report action from 02fdf37

@LordofAvernus

Copy link
Copy Markdown
Collaborator Author

范围收敛为仅插件(sqle-redis-plugin)。本业务仓 PR 不再纳入本期交付,关闭。详见 https://github.com/actiontech/sqle-ee/issues/3186 与插件 MR http://10.186.18.21/sqle/sqle-redis-plugin/-/merge_requests/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant