Repository navigation
feat(conformance): manifest-based feature-conformance standard; eliminate old glob/co-located API - #208
Merged
Conversation
…nate old co-located/glob API Author each feature's conformance as an explicit spec.ts manifest (Conformance.feature) consumed by checkSpec (pure) and checkFeature (ecs). Transforms become single-export pure functions with zero test-tier imports; cases move to inert sibling *.cases.ts with service returns scheduled as data (responses) and calls asserted as effects; service doubles move to *.fake.ts out of the production barrel. A per-package composite tsconfig wall isolates the test tier so a runtime import of it is a compile error. The manifest enforces at compile time: cases coverage, exact hydrate, service completeness, and computedPlugin presence. Removes casesBuilder/derivationsBuilder, the glob transitions discovery, and the old co-located case types. Migrates all seven sample apps and updates the data-ai feature rules to match. Bump to 0.10.20. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the old co-located
{ fn, cases }+import.meta.globconformance pattern with an explicit, compile-checked manifest standard, and eliminates the old API.data/state/spec.tsmanifest (Conformance.feature({...})) consumed byConformance.checkSpec(pure) andConformance.checkFeature(ecs).*.cases.ts(SpecCases/SpecDerivations): data-onlyargs, service returns scheduled as data (responses), calls asserted aseffects.*.fake.ts, out of the productionpublic.tsbarrel.tsconfigwall isolates the test tier: a runtimedata//services/file importing test-tier code is a compile error (TS6307).casescoverage, exacthydrate,servicescompleteness,computedPluginpresence — with positive + negative type-tests.casesBuilder/derivationsBuilder, globtransitions.ts, per-featureconformance-case.ts, old case types, and publicrunSpec/runFeature(kept internal behind the new API).runTransactions/runActions/runComputedsremain as a documented escape hatch fed viaadaptCases.Scope
@adobe/data-testing(new API + guards, old API deleted),@adobe/data-ai(rules rewritten to the new standard), all 7 sample apps migrated, version bump 0.10.20.Verification
pnpm -r typecheck= 0 errors;pnpm run lint= 0;check:workspaceOK.@adobe/data-testingtests (incl. all positive/negative type-tests) green.TS6307) on a runtime→test-tier import.🤖 Generated with Claude Code